From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 692bce5: * lisp/net/tramp-smb.el: Avoid using `add-to-list' on a let-local var Date: Wed, 28 Oct 2015 08:56:51 -0400 Message-ID: References: <20151028002558.5543.17132@vcs.savannah.gnu.org> <87vb9rmegy.fsf@gmx.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1446037040 32731 80.91.229.3 (28 Oct 2015 12:57:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 28 Oct 2015 12:57:20 +0000 (UTC) Cc: emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 28 13:57:12 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZrQHt-00030x-Vd for ged-emacs-devel@m.gmane.org; Wed, 28 Oct 2015 13:57:10 +0100 Original-Received: from localhost ([::1]:37802 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZrQHs-0000tO-PR for ged-emacs-devel@m.gmane.org; Wed, 28 Oct 2015 08:57:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49664) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZrQHk-0000sg-LE for emacs-devel@gnu.org; Wed, 28 Oct 2015 08:57:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZrQHh-0006Gd-EK for emacs-devel@gnu.org; Wed, 28 Oct 2015 08:57:00 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:50256) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZrQHh-0006GQ-93 for emacs-devel@gnu.org; Wed, 28 Oct 2015 08:56:57 -0400 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t9SCupe6022758; Wed, 28 Oct 2015 08:56:52 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 77F10AE250; Wed, 28 Oct 2015 08:56:51 -0400 (EDT) In-Reply-To: <87vb9rmegy.fsf@gmx.de> (Michael Albinus's message of "Wed, 28 Oct 2015 12:15:09 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.2 X-NAI-Spam-Rules: 2 Rules triggered GEN_SPAM_FEATRE=0.2, RV5472=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5472> : inlines <3953> : streams <1528777> : uri <2071875> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:192787 Archived-At: > I'm very sorry, but `delete-dups' does not exist in XEmacs > 21.4. Therefore, I've reverted this commit. Then please use CL's delete-duplicates. Using add-to-list on a let-local variable is really hideous. Stefan