all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: emacs-devel@gnu.org
Cc: Daniel Colascione <dancol@dancol.org>
Subject: Re: [Emacs-diffs] master de76a16: Performance improvements for vc-hg
Date: Mon, 08 Feb 2016 14:55:18 -0500	[thread overview]
Message-ID: <jwvsi13f0b8.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <E1aSqvv-0002TM-Vt@vcs.savannah.gnu.org> (Daniel Colascione's message of "Mon, 08 Feb 2016 18:53:12 +0000")

>>>>> "Daniel" == Daniel Colascione <dan.colascione@gmail.com> writes:
>     Teach vc-hg how to read some Mercurial internal data structures,
>     allowing us to avoid the need to run hg status -A, which is very slow
>     for large repositories.  Fall back to running hg if anything looks
>     funny.  vc-hg now puts the _working directory_ revision in the
>     modeline instead of the file revision, which greatly improves
>     performance and which allows us to again skip running hg in the case
>     that we have an active bookmark.

Thanks Daniel.  Having written the same kind of thing for Bzr (tho it
was much simpler in that case), and taking a step back, I think this
reflects a mistake in VC: we probably just shouldn't provide such
detailed info in the modeline, or at least not until the user makes
explicit use of VC.

Having to go through the trouble of re-implementing part of the VCS to
parse the internal data to figure out the working revision, even though
we have no idea if the user will ever care, is deeply unsatisfactory.


        Stefan



       reply	other threads:[~2016-02-08 19:55 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20160208185311.9470.7389@vcs.savannah.gnu.org>
     [not found] ` <E1aSqvv-0002TM-Vt@vcs.savannah.gnu.org>
2016-02-08 19:55   ` Stefan Monnier [this message]
2016-02-08 20:11     ` [Emacs-diffs] master de76a16: Performance improvements for vc-hg Daniel Colascione
2016-02-08 20:21       ` Eli Zaretskii
2016-02-08 20:28         ` Daniel Colascione
2016-02-08 21:01           ` Eli Zaretskii
2016-02-08 21:09             ` Daniel Colascione
2016-02-08 21:39           ` VC's modeline (was: [Emacs-diffs] master de76a16: Performance improvements for vc-hg) Stefan Monnier
2016-02-08 22:02             ` VC's modeline Óscar Fuentes
2016-02-09 15:15               ` Stefan Monnier
2016-02-09 17:13                 ` Óscar Fuentes
2016-02-10 15:16                   ` Stefan Monnier
2016-02-13 20:01                     ` Dmitry Gutov
2016-02-13  9:33                 ` Markus Triska
2016-02-08 23:29             ` Daniel Colascione
2016-02-13  9:35               ` Markus Triska

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvsi13f0b8.fsf-monnier+emacsdiffs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=dancol@dancol.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.