cl-defmethod not compatible with defmethod?

cl-defmethod not compatible with defmethod?

[Lars Ingebrigtsen]

If I have the following, everything works fine:

(defmethod initialize-instance :AFTER ((this registry-db) slots)

But I get a warning about defmethod being obsolete.

However, with the following:

(cl-defmethod initialize-instance :AFTER ((this registry-db) slots)

compilation stops with

gnus/nnregistry.el:34:1:Error: Unsupported qualifiers in function initialize-instance: (:AFTER)

when trying to require the file where that cl-defmethod is...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: cl-defmethod not compatible with defmethod?

[Eric Abrahamsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> If I have the following, everything works fine:
>
> (defmethod initialize-instance :AFTER ((this registry-db) slots)
>
> But I get a warning about defmethod being obsolete.
>
> However, with the following:
>
> (cl-defmethod initialize-instance :AFTER ((this registry-db) slots)
>
> compilation stops with
>
> gnus/nnregistry.el:34:1:Error: Unsupported qualifiers in function initialize-instance: (:AFTER)
>
> when trying to require the file where that cl-defmethod is...

The qualifiers are supposed to be lower case now.

(Sorry, I've been doing a bunch of eieio stuff recently...)

Re: cl-defmethod not compatible with defmethod?

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Fri, 12 Feb 2016 16:53:49 +1100
> 
> If I have the following, everything works fine:
> 
> (defmethod initialize-instance :AFTER ((this registry-db) slots)
> 
> But I get a warning about defmethod being obsolete.
> 
> However, with the following:
> 
> (cl-defmethod initialize-instance :AFTER ((this registry-db) slots)
> 
> compilation stops with
> 
> gnus/nnregistry.el:34:1:Error: Unsupported qualifiers in function initialize-instance: (:AFTER)
> 
> when trying to require the file where that cl-defmethod is...

Please take a look at the node "Generic Functions" in the ELisp manual
and at the doc string of cl-defmethod: it's ':after' (lower case), not
':AFTER'.

Re: cl-defmethod not compatible with defmethod?

[Lars Ingebrigtsen]

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> The qualifiers are supposed to be lower case now.

Thanks; that did the trick...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: cl-defmethod not compatible with defmethod?

[Stefan Monnier]

No, indeed, the new package is not 100% compatible with the old one.
Look at eieio-compat.el to get some idea about the differences.


        Stefan