From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#23625: viper-tests.el fails in master Date: Fri, 27 May 2016 10:56:39 -0400 Message-ID: References: <871t4oijow.fsf@russet.org.uk> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1464361585 2766 80.91.229.3 (27 May 2016 15:06:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 27 May 2016 15:06:25 +0000 (UTC) Cc: 23625@debbugs.gnu.org, eggert@cs.ucla.edu To: phillip.lord@russet.org.uk (Phillip Lord) Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri May 27 17:06:13 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b6JL3-0006hs-Av for geb-bug-gnu-emacs@m.gmane.org; Fri, 27 May 2016 17:06:13 +0200 Original-Received: from localhost ([::1]:46506 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6JL2-00050d-Iv for geb-bug-gnu-emacs@m.gmane.org; Fri, 27 May 2016 11:06:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50393) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6JCA-0004pR-Vy for bug-gnu-emacs@gnu.org; Fri, 27 May 2016 10:57:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b6JC9-0006g8-W8 for bug-gnu-emacs@gnu.org; Fri, 27 May 2016 10:57:02 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58639) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6JC9-0006g2-SQ for bug-gnu-emacs@gnu.org; Fri, 27 May 2016 10:57:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1b6JC9-00025q-Mu for bug-gnu-emacs@gnu.org; Fri, 27 May 2016 10:57:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 27 May 2016 14:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23625 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-Cc: 23625@debbugs.gnu.org, Emacs bug reports , Paul Eggert Original-Received: via spool by 23625-submit@debbugs.gnu.org id=B23625.14643610168033 (code B ref 23625); Fri, 27 May 2016 14:57:01 +0000 Original-Received: (at 23625) by debbugs.gnu.org; 27 May 2016 14:56:56 +0000 Original-Received: from localhost ([127.0.0.1]:42743 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b6JC3-00025V-SC for submit@debbugs.gnu.org; Fri, 27 May 2016 10:56:56 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:51440) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b6JC1-00025N-Pu for 23625@debbugs.gnu.org; Fri, 27 May 2016 10:56:54 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id u4REudR3018477; Fri, 27 May 2016 10:56:39 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 68FB9600EA; Fri, 27 May 2016 10:56:39 -0400 (EDT) In-Reply-To: <871t4oijow.fsf@russet.org.uk> (Phillip Lord's message of "Thu, 26 May 2016 22:38:23 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5685=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5685> : inlines <4875> : streams <1642228> : uri <2218262> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:118760 Archived-At: > Anyway, I think that the tests are working -- that is, they are picking > up a real bug, caused independently by 088acab3 which was from Stefan. > I've attached a fix. Stefan, can you check I have this right? Indeed, thanks, the patch looks fine. The use of `list` instead of `cons` was because I intended to do (mapc (apply-partially #'apply #'advice-remove) viper--advice-list) but your code is at least as good. Stefan