From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#24340: insert-file-contents calls before-change-functions too late Date: Wed, 31 Aug 2016 13:50:03 -0400 Message-ID: References: <8360qim5sv.fsf@gnu.org> <83vayhkogv.fsf@gnu.org> <83inuhkmkv.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1472665700 5576 195.159.176.226 (31 Aug 2016 17:48:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 31 Aug 2016 17:48:20 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) Cc: 24340@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Aug 31 19:48:17 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bf9cV-0000yQ-3I for geb-bug-gnu-emacs@m.gmane.org; Wed, 31 Aug 2016 19:48:15 +0200 Original-Received: from localhost ([::1]:55359 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bf9cU-0003lP-Qh for geb-bug-gnu-emacs@m.gmane.org; Wed, 31 Aug 2016 13:48:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41602) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bf9cN-0003kQ-FQ for bug-gnu-emacs@gnu.org; Wed, 31 Aug 2016 13:48:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bf9cI-0000TY-Gn for bug-gnu-emacs@gnu.org; Wed, 31 Aug 2016 13:48:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:47919) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bf9cI-0000TR-DD for bug-gnu-emacs@gnu.org; Wed, 31 Aug 2016 13:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bf9cI-0004mH-1b for bug-gnu-emacs@gnu.org; Wed, 31 Aug 2016 13:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 31 Aug 2016 17:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24340 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24340-submit@debbugs.gnu.org id=B24340.147266562718300 (code B ref 24340); Wed, 31 Aug 2016 17:48:02 +0000 Original-Received: (at 24340) by debbugs.gnu.org; 31 Aug 2016 17:47:07 +0000 Original-Received: from localhost ([127.0.0.1]:45631 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bf9bO-0004l5-C0 for submit@debbugs.gnu.org; Wed, 31 Aug 2016 13:47:06 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:64388) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bf9bN-0004kW-Cs for 24340@debbugs.gnu.org; Wed, 31 Aug 2016 13:47:05 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0ByEgCJI6tX/+V1oWxdGwEBgyiES4VQsF2BfYYXBAICgV07EgEBAQEBAQFdJ4RfAQEDAVYjBQsLNBIUGA0kiDwIwVwBAQEBBgIlineJfh0BBJk8mFmFfI5wgTwlDiGCEhyBaCCHXgEBAQ X-IPAS-Result: A0ByEgCJI6tX/+V1oWxdGwEBgyiES4VQsF2BfYYXBAICgV07EgEBAQEBAQFdJ4RfAQEDAVYjBQsLNBIUGA0kiDwIwVwBAQEBBgIlineJfh0BBJk8mFmFfI5wgTwlDiGCEhyBaCCHXgEBAQ X-IronPort-AV: E=Sophos;i="5.28,500,1464667200"; d="scan'208";a="270545769" Original-Received: from 108-161-117-229.dsl.teksavvy.com (HELO ceviche.home) ([108.161.117.229]) by smtp.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 31 Aug 2016 13:46:59 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id D244066287; Wed, 31 Aug 2016 13:50:03 -0400 (EDT) In-Reply-To: <83inuhkmkv.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 31 Aug 2016 18:03:12 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:122814 Archived-At: > Since I believe master will be used for 25.2, [ Making an effort not to comment on that ;-) ] > we cannot currently push anything that must wait for 26. I can wait for this issue to clear up. >> > I think a cleaner way is to change the model of how we partition >> > piecemeal changes, when we signal the changes and when don't, when we >> > ask the user about supersession-threat, etc. The current model is >> > fundamentally flawed, if we want to use the buffer-change hooks in the >> > ways that emerged from these discussions. >> All I care about is for any change to the buffer to be announced by >> a prior b-c-f. > My proposed simple change satisfies this requirement, albeit the > effect is less optimal. Yes, as I said, I prefer my patch, but your suggestion is acceptable as well. Stefan