From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Fixing "Unknown slot" warnings Date: Sun, 29 Jan 2017 12:07:13 -0500 Message-ID: References: <87sho2m458.fsf@engster.org> <87o9ypnako.fsf@engster.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1485709694 19421 195.159.176.226 (29 Jan 2017 17:08:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 29 Jan 2017 17:08:14 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jan 29 18:08:02 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXsxN-00040a-Qu for ged-emacs-devel@m.gmane.org; Sun, 29 Jan 2017 18:08:01 +0100 Original-Received: from localhost ([::1]:56086 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXsxT-0006oT-2y for ged-emacs-devel@m.gmane.org; Sun, 29 Jan 2017 12:08:07 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41310) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXsxM-0006o8-3j for emacs-devel@gnu.org; Sun, 29 Jan 2017 12:08:01 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cXsxI-0006OM-SY for emacs-devel@gnu.org; Sun, 29 Jan 2017 12:08:00 -0500 Original-Received: from [195.159.176.226] (port=34633 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cXsxI-0006OG-MF for emacs-devel@gnu.org; Sun, 29 Jan 2017 12:07:56 -0500 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1cXswt-0001AN-QK for emacs-devel@gnu.org; Sun, 29 Jan 2017 18:07:31 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 19 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:sHLSyVQLgv7tEpclef1bhrmjATk= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:211727 Archived-At: > After looking at the code, it seems all slot symbols are shoved into > `eieio--known-slot-names' and the byte-compiler checks if a slot is in > there, regardless of the class being used. So the following would > already do the trick: > (defmacro eieio-declare-slot (name) > "Declares slot to be available at runtime." > `(eval-when-compile (cl-pushnew ,name eieio--known-slot-names))) If you mean something to add to eieio, then yes, that's about right (tho you could also do it as (defmacro eieio-declare-slot (name) (cl-pushnew name eieio--known-slot-names) nil). My `defclass` solution was meant for use in code that must work with older Emacsen and/or older eieio without relying on internals like eieio--known-slot-names. Stefan