bug#27057: 26.0.50; Equal defstruct objects not recognized in puthash

bug#27057: 26.0.50; Equal defstruct objects not recognized in puthash

[Stefan Monnier]

Package: Emacs
Version: 26.0.50

It looks like the new records-based code introduced a bug in the way
records are handled as keys in hash-tables when the test is `equal`:

    (progn
      (cl-defstruct sm-foo a b)
      (setq sm-hash (make-hash-table :test 'equal))
      (puthash (make-sm-foo :a 4 :b 6) "test1" sm-hash)
      (puthash (make-sm-foo :a 4 :b 6) "test2" sm-hash)
      (hash-table-count sm-hash))

this code return 2 here instead of 1.  Lars, could you take a look at it?


        Stefan

bug#26639: bug#27057: 26.0.50; Equal defstruct objects not recognized in puthash

[Stefan Monnier]

>     (progn
>       (cl-defstruct sm-foo a b)
>       (setq sm-hash (make-hash-table :test 'equal))
>       (puthash (make-sm-foo :a 4 :b 6) "test1" sm-hash)
>       (puthash (make-sm-foo :a 4 :b 6) "test2" sm-hash)
>       (hash-table-count sm-hash))
>
> this code return 2 here instead of 1.

This should be fixed now,


        Stefan

bug#26639: bug#27057: 26.0.50; Equal defstruct objects not recognized in puthash

[Michael Albinus]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

Hi Stefan

>> this code return 2 here instead of 1.
>
> This should be fixed now,

Thanks. But for Tramp, I'll keep the list type, due to backward compatibility.

>         Stefan

Best regards, Michael.