From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Re: Changing a cl-defstruct definition in a published package
Date: Sun, 15 Jul 2018 21:51:09 -0400 [thread overview]
Message-ID: <jwvsh4k9daa.fsf-monnier+gmane.emacs.devel@gnu.org> (raw)
In-Reply-To: 285c8ce6-3cc0-a4ca-55c2-d95e68f05d22@gmail.com
>> Note that the recompilation issue can be solved outside of package.el:
>> - "recompile package" doesn't have to be in package.el (tho it is its
>> most natural place).
>> - you could have code in flycheck.el that does:
>>
>> (eval-when-compile
>> (dolist (pkg (find-pkgs-using-the-old-flycheck-object-layout))
>> (recompile-package pkg)))
>>
>> so it will be executed when flycheck is compiled.
>
> That's a interesting idea, and a good point.
> But wouldn't it have to run *after* Flycheck is compiled?
I don't think so, no (by the time we're compiling the file, the package
is already installed and activated).
You'd need to add some mechanism to avoid infinite-recursion, ideally by
somehow checking that we're running this eval-when-compile because of
a compilation and not because we're loading the .el file.
We could use an ugly hack like (guaranteed 100% untested):
(eval-when-compile
;; When handling eval-when-compile, the byte-compiler compiles
;; the form before evaluating it, so in that case the
;; (lambda (x) (+ x 1)) below will be turned into byte-code before
;; we get to the `if` test. In contrast, when we're just loading
;; the .el file, the `lambda` is either left as is or turned into
;; a (closure ...) object (depending on lexical-binding), but in
;; either case it won't be turned into a byte-code.
;; Of course, all of this can be subject to change :-(
(when (byte-code-function-p (lambda (x) (+ x 1)))
;; We're in the middle of byte-compiling this file.
(dolist (pkg (find-pkgs-using-the-old-flycheck-object-layout))
(recompile-package pkg))))
Better would be to introduce some dedicated feature, like
`eval-only-when-compile`.
Stefan
next prev parent reply other threads:[~2018-07-16 1:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 20:12 Changing a cl-defstruct definition in a published package Clément Pit-Claudel
2018-07-13 17:01 ` João Távora
2018-07-13 17:38 ` Basil L. Contovounesios
2018-07-13 18:21 ` Clément Pit-Claudel
2018-07-13 18:26 ` Clément Pit-Claudel
2018-07-13 19:38 ` João Távora
2018-07-13 19:52 ` Clément Pit-Claudel
2018-07-13 20:40 ` Stefan Monnier
2018-07-13 21:07 ` Clément Pit-Claudel
2018-07-14 3:36 ` Stefan Monnier
2018-07-15 4:25 ` Clément Pit-Claudel
2018-07-15 13:11 ` Stefan Monnier
2018-07-15 13:25 ` Clément Pit-Claudel
2018-07-16 1:51 ` Stefan Monnier [this message]
2018-07-30 21:52 ` Clément Pit-Claudel
2018-07-30 22:49 ` Stefan Monnier
2018-07-31 3:28 ` Clément Pit-Claudel
-- strict thread matches above, loose matches on Subject: below --
2018-07-19 20:27 Jake
2018-07-19 21:10 ` Stefan Monnier
2018-07-19 21:34 ` Jake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvsh4k9daa.fsf-monnier+gmane.emacs.devel@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.