From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#30452: [PATCH] Use 'make-sparse-keymap' rather than 'copy-keymap' Date: Sat, 19 Jan 2019 10:33:12 -0500 Message-ID: References: <8736ptiz1b.fsf@gmail.com> <83lg3hax8i.fsf@gnu.org> NNTP-Posting-Host: ciao.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ciao.gmane.org 1547912048 88871 195.159.176.228 (19 Jan 2019 15:34:08 GMT) X-Complaints-To: usenet@ciao.gmane.org NNTP-Posting-Date: Sat, 19 Jan 2019 15:34:08 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Alex Branham , 30452@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 19 16:34:06 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1gksdD-000Mz6-W8 for geb-bug-gnu-emacs@m.gmane.org; Sat, 19 Jan 2019 16:34:00 +0100 Original-Received: from localhost ([127.0.0.1]:57003 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gksdN-0004KP-2s for geb-bug-gnu-emacs@m.gmane.org; Sat, 19 Jan 2019 10:34:09 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:52587) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gksdH-0004K5-AS for bug-gnu-emacs@gnu.org; Sat, 19 Jan 2019 10:34:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gksdG-0004zG-PR for bug-gnu-emacs@gnu.org; Sat, 19 Jan 2019 10:34:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38721) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gksdG-0004z6-M4 for bug-gnu-emacs@gnu.org; Sat, 19 Jan 2019 10:34:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gksdG-0008QA-7f for bug-gnu-emacs@gnu.org; Sat, 19 Jan 2019 10:34:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Jan 2019 15:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30452 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30452-submit@debbugs.gnu.org id=B30452.154791199832313 (code B ref 30452); Sat, 19 Jan 2019 15:34:02 +0000 Original-Received: (at 30452) by debbugs.gnu.org; 19 Jan 2019 15:33:18 +0000 Original-Received: from localhost ([127.0.0.1]:38002 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gkscY-0008P6-0o for submit@debbugs.gnu.org; Sat, 19 Jan 2019 10:33:18 -0500 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:54198) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gkscV-0008Ox-4J for 30452@debbugs.gnu.org; Sat, 19 Jan 2019 10:33:16 -0500 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id x0JFXDOV025719; Sat, 19 Jan 2019 10:33:13 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id DF7326AB69; Sat, 19 Jan 2019 10:33:12 -0500 (EST) In-Reply-To: <83lg3hax8i.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 19 Jan 2019 10:05:17 +0200") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6464=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6464> : inlines <6998> : streams <1810544> : uri <2782420> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:154587 Archived-At: >> (defvar tabulated-list-mode-map >> - (let ((map (copy-keymap special-mode-map))) >> + (let ((map (make-sparse-keymap))) >> (set-keymap-parent map button-buffer-map) Nowadays we can inherit from both with something like (set-keymap-parent map (make-composed-keymap button-buffer-map special-mode-map)) -- Stefan