From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: charles@aurox.ch (Charles A. Roelli)
Cc: 32991@debbugs.gnu.org
Subject: bug#32991: 27.0.50; diff-auto-refine-mode a no-op
Date: Mon, 11 Feb 2019 15:14:12 -0500 [thread overview]
Message-ID: <jwvsgwuozqt.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <m21s5dwtw7.fsf@aurox.ch> (Charles A. Roelli's message of "Tue, 15 Jan 2019 21:25:12 +0100")
>> This change seems unrelated. I'd rather we stick to the refinement itself.
> Without this change, other functions in diff-mode (such as
> diff--font-lock-syntax) calling diff-hunk-next accidentally trigger
> hunk refinement if 'diff-refine' is 'navigation'.
Ah, right, makes sense. Could we fix this more directly by using
`called-interactively` instead?
> Incidentally, I left out the auto-recentering and buffer
> restriction-changing parts of the old diff-hunk-next and
> diff-hunk-prev, since these behaviors do not match other navigation
> commands.
Indeed, I see several changes in there, which is why I'd rather we
separate them into another patch.
[ FWIW I never used the restriction (I coded it up only to mach the
featureset of some earlier diff-mode I'd found somewhere), but I would
miss the recentering. More to the point, rather than removing the
recentering, I'd like to improve it (so it tries harder to make the
whole hunk visible when possible). ]
Other than that, LGTM.
Stefan
next prev parent reply other threads:[~2019-02-11 20:14 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 18:30 bug#32991: 27.0.50; diff-auto-refine-mode a no-op Charles A. Roelli
2018-10-08 21:00 ` Stefan Monnier
2018-10-09 19:15 ` Charles A. Roelli
2018-10-09 19:54 ` Stefan Monnier
2018-10-10 18:31 ` Charles A. Roelli
2018-10-10 19:21 ` Stefan Monnier
2018-10-13 13:42 ` Charles A. Roelli
2018-10-13 18:51 ` Stefan Monnier
2019-01-13 14:36 ` Charles A. Roelli
2019-01-13 20:03 ` Charles A. Roelli
2019-01-13 23:33 ` Stefan Monnier
2019-01-15 20:25 ` Charles A. Roelli
2019-02-11 20:14 ` Stefan Monnier [this message]
2019-02-18 19:06 ` Charles A. Roelli
2019-02-18 20:44 ` Stefan Monnier
2019-02-24 16:12 ` Charles A. Roelli
2019-02-27 15:04 ` Stefan Monnier
2019-03-03 20:51 ` Charles A. Roelli
2019-03-05 21:38 ` Juri Linkov
2019-03-07 19:23 ` Charles A. Roelli
2019-01-30 21:04 ` Juri Linkov
2019-02-01 7:38 ` Stefan Monnier
2019-02-03 11:42 ` Charles A. Roelli
2019-02-03 12:37 ` Stefan Monnier
2019-02-03 14:19 ` Charles A. Roelli
2019-02-11 20:15 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvsgwuozqt.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=32991@debbugs.gnu.org \
--cc=charles@aurox.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.