From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Stefan Monnier <monnier@iro.umontreal.ca>
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH] lexical-binding in rx.el
Date: Thu, 14 Feb 2019 09:11:59 -0500
Message-ID: <jwvsgwqmpcz.fsf-monnier+emacs@gnu.org>
References: <DC696C03-6BA4-455F-BEC6-F6E035D624BD@acm.org>
Mime-Version: 1.0
Content-Type: text/plain
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="85963"; mail-complaints-to="usenet@blaine.gmane.org"
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
To: emacs-devel@gnu.org
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 14 15:26:22 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1guHy1-000MFN-1H
	for ged-emacs-devel@m.gmane.org; Thu, 14 Feb 2019 15:26:21 +0100
Original-Received: from localhost ([127.0.0.1]:49396 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1guHxz-00039z-Vj
	for ged-emacs-devel@m.gmane.org; Thu, 14 Feb 2019 09:26:20 -0500
Original-Received: from eggs.gnu.org ([209.51.188.92]:41997)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ged-emacs-devel@m.gmane.org>) id 1guHxZ-0002vZ-Q3
	for emacs-devel@gnu.org; Thu, 14 Feb 2019 09:25:54 -0500
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ged-emacs-devel@m.gmane.org>) id 1guHn7-0003fo-Tk
	for emacs-devel@gnu.org; Thu, 14 Feb 2019 09:15:10 -0500
Original-Received: from [195.159.176.226] (port=39434 helo=blaine.gmane.org)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <ged-emacs-devel@m.gmane.org>)
	id 1guHn5-0003d4-Tt
	for emacs-devel@gnu.org; Thu, 14 Feb 2019 09:15:04 -0500
Original-Received: from list by blaine.gmane.org with local (Exim 4.89)
	(envelope-from <ged-emacs-devel@m.gmane.org>) id 1guHn4-0008ZL-5Y
	for emacs-devel@gnu.org; Thu, 14 Feb 2019 15:15:02 +0100
X-Injected-Via-Gmane: http://gmane.org/
Cancel-Lock: sha1:WmjqRoa2mnnBrwIo00uendLLqZA=
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 195.159.176.226
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel/>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:233315
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/233315>

> * lisp/emacs-lisp/rx.el: Use lexical-binding.
> (rx-form): Use `let' to bind the dynamic variable `rx-parent' instead
> of binding it as an argument.

LGTM, thanks,


        Stefan