From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: disk-usage Date: Sun, 24 Feb 2019 15:24:04 -0500 Message-ID: References: <87imxgmacr.fsf@ambrevar.xyz> <874l8z7cmi.fsf@gmx.de> <874l8zr0cs.fsf@ambrevar.xyz> <87zhqr5x81.fsf@gmx.de> <8736ojqyj1.fsf@ambrevar.xyz> <87mumqkhkm.fsf@ambrevar.xyz> <87bm31nm5w.fsf@ambrevar.xyz> <87ftsdnfq7.fsf@ambrevar.xyz> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="167943"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Emacs developers To: Pierre Neidhardt Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 24 21:24:52 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gy0KS-000hbJ-Bj for ged-emacs-devel@m.gmane.org; Sun, 24 Feb 2019 21:24:52 +0100 Original-Received: from localhost ([127.0.0.1]:55553 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gy0KR-00011r-3z for ged-emacs-devel@m.gmane.org; Sun, 24 Feb 2019 15:24:51 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58239) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gy0Jr-00011k-0l for emacs-devel@gnu.org; Sun, 24 Feb 2019 15:24:15 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gy0Jn-00039g-Td for emacs-devel@gnu.org; Sun, 24 Feb 2019 15:24:14 -0500 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:47516) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gy0Jk-000389-VO for emacs-devel@gnu.org; Sun, 24 Feb 2019 15:24:09 -0500 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id x1OKO4uL010824; Sun, 24 Feb 2019 15:24:04 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 3C85E6A17C; Sun, 24 Feb 2019 15:24:04 -0500 (EST) In-Reply-To: <87ftsdnfq7.fsf@ambrevar.xyz> (Pierre Neidhardt's message of "Sun, 24 Feb 2019 20:33:52 +0100") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6489=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6489> : inlines <7020> : streams <1813995> : uri <2801708> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233581 Archived-At: > Purcell argues that Stefan should not have used `eval-when-compile' for > `cl-lib`: > > --8<---------------cut here---------------start------------->8--- > (eval-when-compile (require 'cl-lib)) > --8<---------------cut here---------------end--------------->8--- > > because `cl-first' is used in some places. > > I'd tend to agree with Purcell. Thoughts? If you use #'cl-first then you definitely need to remove the eval-when-compile, indeed. But if you have direct calls to cl-first, then they will be compiled into byte-code which do not refer to `cl-first` any more (IOW the cl-first definition has been inlined by the compiler). Hence your code should still work with eval-when-compile. [ Yes: the exact conditions under which a library can be `require`d inside `eval-when-compile` can be pretty subtle. ] I used eval-when-compile because it seemed to work, but feel free to change it, whether for technical reasons or just out of personal preference. Stefan