From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: emacs-26 8f18d12: Improve documentation of decoding into a unibyte buffer Date: Tue, 28 May 2019 07:55:40 -0400 Message-ID: References: <20190525191039.14136.23307@vcs0.savannah.gnu.org> <20190525191040.CCD6C207F5@vcs0.savannah.gnu.org> <88F01F35-BE24-4F6E-B832-64AFE28CD06B@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="199099"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 28 13:56:34 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hVaiX-000pff-7y for ged-emacs-devel@m.gmane.org; Tue, 28 May 2019 13:56:33 +0200 Original-Received: from localhost ([127.0.0.1]:33138 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVaiW-0003yT-25 for ged-emacs-devel@m.gmane.org; Tue, 28 May 2019 07:56:32 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44652) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVahu-0003xD-DY for emacs-devel@gnu.org; Tue, 28 May 2019 07:55:55 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hVaht-0004ke-Gg for emacs-devel@gnu.org; Tue, 28 May 2019 07:55:54 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:3599) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hVahj-0004WI-Hu; Tue, 28 May 2019 07:55:43 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 2A310810F4; Tue, 28 May 2019 07:55:43 -0400 (EDT) Original-Received: from mail02.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id E638B80D8B; Tue, 28 May 2019 07:55:41 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1559044541; bh=HODt77F0c0RG0cycWwFKn99sbualsJFV2cz0mOQ0vHo=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=VeHP9Eb4o/KxTkx8GmzDXfxKmjsnx6b0syaqcjomo4igE5FXsaSPBqkZItmnkOPKr J5mHGV1uTVhrg3UTRVNfXVmJXMgkJRF4WNPml63n9L6/jel4Lsr+g9bThirZ+B9+Ng ShcfsYCjcemw/INrkIC/xhaRqCD9pPGYkzzIalntfuuH8ANZXg7BDiBJIJxESSBJKl 2N/G6Yiz+jRo1Jn/IhiKOrwVorP+vl70CQPAbWSLaWo96uqAyUuhWOzTN3iJ9AsNRN mzgT3xYtD6NrcUZhTePr7moamFpYBAFAlW8fBGmnio2HMX4WMVhpnFeIUbNGX0UcRt XyrxuBKx61u5g== Original-Received: from pastel (192-171-44-92.cpe.pppoe.ca [192.171.44.92]) by mail02.iro.umontreal.ca (Postfix) with ESMTPSA id C086912098E; Tue, 28 May 2019 07:55:41 -0400 (EDT) In-Reply-To: <88F01F35-BE24-4F6E-B832-64AFE28CD06B@gnu.org> (Eli Zaretskii's message of "Tue, 28 May 2019 07:40:39 +0300") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237088 Archived-At: >> and according to my quick investigation, all callers pass a string >> that's coming straight from encode-coding-string or >> encode-coding-char, >> so the argument should *always* be unibyte, AFAICT. >> >> Hence according to my reading of the code, this call to >> string-as-unibyte will always just return its argument unchanged. > That's not entirely true, because encode-coding-char can return a multibyte > string. That's weird. When would that happen? Stefan