From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 0528a7c: Ensure that expand-file-name returns an absolute file name Date: Mon, 08 Jul 2019 19:13:52 -0400 Message-ID: References: <20190708223951.10291.7621@vcs0.savannah.gnu.org> <20190708223953.3172920BD5@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="198630"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Ken Brown Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 09 01:27:41 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hkd2r-000pH9-6M for ged-emacs-devel@m.gmane.org; Tue, 09 Jul 2019 01:27:41 +0200 Original-Received: from localhost ([::1]:45552 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hkcpu-0002le-Cr for ged-emacs-devel@m.gmane.org; Mon, 08 Jul 2019 19:14:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60959) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hkcpa-0002j5-NO for emacs-devel@gnu.org; Mon, 08 Jul 2019 19:13:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hkcpZ-0000zJ-59 for emacs-devel@gnu.org; Mon, 08 Jul 2019 19:13:58 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:38766) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hkcpY-0000y6-P0 for emacs-devel@gnu.org; Mon, 08 Jul 2019 19:13:57 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 1E5FE100737; Mon, 8 Jul 2019 19:13:54 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id E202A10067D; Mon, 8 Jul 2019 19:13:52 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1562627632; bh=LB08TUKuBy9RH/mbBPh9kctq1nYzj44OAuD8xvqzzFQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=kb7LvW/hCd25mAAyvq8Fovecykgo5iSpmd1Y8PzBYrYvgXySqWk0Ih2QKf7fbuMXV jaram5q/JOPRBqvh26b0a7JnSUgThvf+X91Ln8BOnVGdVInwxeKiIdAon6YKVk2aBs nFhu+h76524j3TiRxSqO3Mxzr36qmMu72kVUjU7k5E08gXArYKf4X0sWRLsqTtSqmG ISt99lWPSyQ/naxdCYmL88QNM8LIRQZ9E+IRQLFsp16Jh69C+mvzGUcx4z/jjeeeUT lCFTM8j9flE+9wANq/GH4lEK+PKjNyXORJ62YDIDocy+Ls2eNtq/skHjMcAcmopM2+ knaRjlwCDMP/Q== Original-Received: from alfajor (76-10-138-228.dsl.teksavvy.com [76.10.138.228]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id B78C812039B; Mon, 8 Jul 2019 19:13:52 -0400 (EDT) In-Reply-To: <20190708223953.3172920BD5@vcs0.savannah.gnu.org> (Ken Brown's message of "Mon, 8 Jul 2019 18:39:52 -0400 (EDT)") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238421 Archived-At: > * src/fileio.c (Fexpand_file_name): Don't directly use the current > buffer's default-directory if it is relative. Instead replace it > by its expansion relative to invocation-directory. (Bug#36502) I don't think invocation-directory is a better choice than any other directory. A relative `default-directory` value is an error. We should signal that error rather than try and paper over it. Stefan