From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: master ea93326: Add `union' and `intersection' to rx (bug#37849)
Date: Fri, 13 Dec 2019 08:55:59 -0500 [thread overview]
Message-ID: <jwvsglotjpk.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <67645170-D29F-4C77-99F4-09706856CEEB@acm.org> ("Mattias \=\?windows-1252\?Q\?Engdeg\=E5rd\=22's\?\= message of "Thu, 12 Dec 2019 23:48:40 +0100")
>> But as a user now I wonder what's the difference between `or` and
>> `union` and also why there has to be a difference.
> You've convinced me -- plain 'or' is better. I've pushed a patch.
> As a pleasing side-effect, some existing rx expressions are now more optimised:
> (or (any "a-z") (any "0-9")) now becomes "[0-9a-z]" instead of "[a-z]\\|[0-9]".
BTW, if you like the fact that the old system made it clear&sure that
the result is optimized, then I think it should be introduced as
a syntax like
(any (union "a-z" (intersection "0-9" "6-a")))
-- Stefan
next prev parent reply other threads:[~2019-12-13 13:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191210213842.5388.30110@vcs0.savannah.gnu.org>
[not found] ` <20191210213843.EB6A520A23@vcs0.savannah.gnu.org>
2019-12-10 21:52 ` master ea93326: Add `union' and `intersection' to rx (bug#37849) Stefan Monnier
2019-12-11 11:17 ` Mattias Engdegård
2019-12-11 15:10 ` Stefan Monnier
2019-12-12 22:48 ` Mattias Engdegård
2019-12-13 13:55 ` Stefan Monnier [this message]
2019-12-13 17:03 ` Mattias Engdegård
2019-12-13 17:13 ` Stefan Monnier
2019-12-13 17:43 ` Mattias Engdegård
2019-12-13 23:03 ` Stefan Monnier
2019-12-15 11:08 ` Mattias Engdegård
2019-12-15 14:53 ` Stefan Monnier
2019-12-15 19:23 ` Mattias Engdegård
2019-12-15 20:04 ` Stefan Monnier
2019-12-15 20:42 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvsglotjpk.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=mattiase@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.