From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Date: Fri, 24 Jan 2020 09:11:55 -0500 Message-ID: References: <288610218.111246.1578330546916@office.mailbox.org> <780526337.114357.1578556168662@office.mailbox.org> <944631362.128066.1578605073103@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="46305"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 38992@debbugs.gnu.org, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , waah@yellowfrog.io To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 24 15:13:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iuzhx-000Bzb-Da for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 24 Jan 2020 15:13:13 +0100 Original-Received: from localhost ([::1]:42914 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuzhw-0001RM-HU for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 24 Jan 2020 09:13:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41162) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuzhn-0001PD-HW for bug-gnu-emacs@gnu.org; Fri, 24 Jan 2020 09:13:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iuzhm-0003nT-IZ for bug-gnu-emacs@gnu.org; Fri, 24 Jan 2020 09:13:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47611) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iuzhm-0003nF-CU for bug-gnu-emacs@gnu.org; Fri, 24 Jan 2020 09:13:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iuzhm-00021l-7S for bug-gnu-emacs@gnu.org; Fri, 24 Jan 2020 09:13:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 Jan 2020 14:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs Original-Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.15798751307715 (code B ref 38992); Fri, 24 Jan 2020 14:13:02 +0000 Original-Received: (at 38992) by debbugs.gnu.org; 24 Jan 2020 14:12:10 +0000 Original-Received: from localhost ([127.0.0.1]:53580 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iuzgw-00020N-0f for submit@debbugs.gnu.org; Fri, 24 Jan 2020 09:12:10 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:45190) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iuzgv-00020B-0y for 38992@debbugs.gnu.org; Fri, 24 Jan 2020 09:12:09 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 5AB87100A9C; Fri, 24 Jan 2020 09:12:03 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 8F8E71009B3; Fri, 24 Jan 2020 09:12:01 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1579875121; bh=9Ab6DPA4MkKPWCqYpSz/vmqg8+QF0pM267KWFwuTt60=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=HpMR5EEAsTXkXE9PKpUje2Q996FiImZ0TeEeB3268uETADndJDFQo8mZ50MwLfaHX fr57pMqwTtsBJ4UgqY8WXWB2mTZsuIaDKUrv0PAqePH1Py6UbVfGvKWmfKqqYTrdng qMWs8uB0oCvVr/w4UGeJHLC1wFLAmlNqfY33Be51J9rSnhxwUGSNadqSGtOElePu6g Fa/q/6HPtfnvWCC+b4nq31Uw2svs4i7J9hPbJqBAeRHMxU9x7yf+TJ2N3bkPnONH4I AE0X6FUvIw65iM+iPaI5+YJxzyL6TUGfBLrHNXipF2y5p8Q7zplIgxNOjfLEe0oJUz DYjgA5USF00AA== Original-Received: from pastel (69-196-141-61.dsl.teksavvy.com [69.196.141.61]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 43F1C120C73; Fri, 24 Jan 2020 09:12:01 -0500 (EST) In-Reply-To: <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> (Dmitry Gutov's message of "Fri, 24 Jan 2020 01:07:15 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175216 Archived-At: >> We could introduce a new `minibuffer-require-match` variable (and mark >> `minibuffer-completion-confirm` obsolete). > Why don't we just co-opt the older variable. It's arguably breaking compatibility. But you might be right that maybe it's a non issue. A quick `grep` shows that outside Emacs itself, at least Helm might be affected. > Here's another issue related to the previous proposed fix: why *would* M-j > exit minibuffer in all cases? It currently doesn't honor REQUIRE-MATCH=t (or > the confirm- values, but I don't care about that). The default > completing-read, as well as icomplete-mode, both honor it. The patch > 2 fixes that. Sounds like a plain bug fix, yes. > --- a/lisp/minibuffer.el > +++ b/lisp/minibuffer.el > @@ -1386,7 +1386,10 @@ minibuffer-force-complete-and-exit > (minibuffer-prompt-end) (point-max) #'exit-minibuffer > ;; If the previous completion completed to an element which fails > ;; test-completion, then we shouldn't exit, but that should be rare. > - (lambda () (minibuffer-message "Incomplete")))) > + (lambda () > + (if minibuffer-completion-predicate > + (minibuffer-message "Incomplete") > + (exit-minibuffer))))) I think this is a typo for `minibuffer-completion-confirm`, right? Stefan