all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Alex Branham <alex.branham@gmail.com>
Cc: Gregory Heytings <ghe@sdf.org>, 42383@debbugs.gnu.org
Subject: bug#42383: 28.0.50; Two bugs with M-x compile
Date: Thu, 16 Jul 2020 18:37:08 -0400	[thread overview]
Message-ID: <jwvsgdrrszm.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87zh7zrvf6.fsf@gmail.com> (Alex Branham's message of "Thu, 16 Jul 2020 17:39:57 -0400")

>>         * lisp/shell.el (shell-dynamic-complete-functions): Move
>>         pcomplete-completions-at-point down the list so that filename
>>         completion has a chance to complete before pcompletion.
>>         
>>         Fixes bug#34330
>>
>> yet, `pcomplete-completions-at-point` is supposed to perform filename
>> completion also (via `pcomplete-default-completion-function`), so
>> I think `pcomplete-completions-at-point` should come first and I suspect
>> that the problem in bug#34330 is internal to pcomplete and the above
>> commit just worked around it.
>
> I find pcomplete really confusing (why is it that there's a whole second
> kind of completion framework outside completion-at-point?).

They are not competing nor redundant: pcomplete.el is a system that lets
one explain how to split a line into fields and which completion table
applies to which field (i.e. explain that in a shell command the first
element should be an executable, while the rest will depend on which
executable was used in the first element, ...).

There is sadly some redundancy here in that originally pcomplete.el also
provided a completion UI (under the command `pcomplete`) and this one is
indeed competing with the `completion-at-point` command.
But this part is now obsolete.


        Stefan






  reply	other threads:[~2020-07-16 22:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-15 23:23 bug#42383: 28.0.50; Two bugs with M-x compile Gregory Heytings via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-07-16  9:48 ` Gregory Heytings via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-07-16 15:17   ` Eli Zaretskii
2020-07-16 18:55     ` Stefan Monnier
2020-07-16 21:39       ` Alex Branham
2020-07-16 22:37         ` Stefan Monnier [this message]
2020-07-18  8:22         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvsgdrrszm.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=42383@debbugs.gnu.org \
    --cc=alex.branham@gmail.com \
    --cc=ghe@sdf.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.