From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master b8062be 3/5: Remove some compat code from eudc-bob.el Date: Thu, 13 Aug 2020 09:58:15 -0400 Message-ID: References: <20200812175454.4839.92908@vcs0.savannah.gnu.org> <20200812175456.C5D122172E@vcs0.savannah.gnu.org> <874kp7lpda.fsf@gnus.org> <87mu2zhssl.fsf@gnus.org> <83imdmn0vr.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33444"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Aug 13 15:59:01 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k6Dkz-0008X0-Ie for ged-emacs-devel@m.gmane-mx.org; Thu, 13 Aug 2020 15:59:01 +0200 Original-Received: from localhost ([::1]:40674 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6Dky-0005Dp-IS for ged-emacs-devel@m.gmane-mx.org; Thu, 13 Aug 2020 09:59:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41916) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6DkT-0004n5-QM for emacs-devel@gnu.org; Thu, 13 Aug 2020 09:58:29 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:10926) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6DkR-0006ju-Lu; Thu, 13 Aug 2020 09:58:29 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id BEEBE100363; Thu, 13 Aug 2020 09:58:25 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id D990110031E; Thu, 13 Aug 2020 09:58:16 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1597327096; bh=lIJ8gyKEsLlj9Sf2NZMqLKxIdEvxyevJFxDBnuqjMsY=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ZYtIXQSESfjzm6yvmTJIFl0egtVUu+6Akkt1V4hJ6d3y4qzbtCgs3vK6cUciQE/ep 1Vi6w1VId/Vg5QpSi5/BQ92weUqediX/3DGUfL4OGU1v+7zgLlicGTYsiICG6r7A7p RwDJyj9jQtzxwGvwluhxjb/6AhO6i35gLPazEgTu5RVMDLGKW5BtEWoFaJPccV/j+F 9yS4A5Wc6zcseClH6E8nqV1KdU8iRdjSQpRB+Sjw45TBhhuzu+S1cdk8GSwq77m5yU kmuLja3emqUuuMqXUz2YiuQWAtwF45D+aKQnVui9pkFk08BdJCpsg95/f60JOtMCdI FHQSo6SlRj17w== Original-Received: from alfajor (unknown [45.72.246.108]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 7199A12036E; Thu, 13 Aug 2020 09:58:16 -0400 (EDT) In-Reply-To: <83imdmn0vr.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 13 Aug 2020 16:14:48 +0300") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/13 09:33:20 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:253729 Archived-At: > I think we can simply delete the line that sets > buffer-file-coding-system: in a unibyte buffer it doesn't > matter anyway. IIRC it can make a difference w.r.t line-endings. > (And it's wrong to use 'binary' for producing files that will > be processed by programs other than Emacs, because 'binary' spills out > the Emacs internal representation of characters.) It's definitely not wrong for unibyte buffers where there's no "internal representation of characters" that can spill out ;-) And AFAIK it's not wrong for multybyte buffers: - Either the content of the buffer is limited to ascii and eight-bit chars in which case the output is exactly right. - Or there are other chars and there is simply no correct output. We should likely signal an error in this case, tho we probably just end up exposing the internal utf-8-like encoding instead, indeed. Still the error is not necessarily in the use of `binary` in that case but in the actual content of the buffer. Stefan