From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Cc: Po Lu <luangruo@yahoo.com>
Subject: Re: master 18ec3fcce9: Restore pending_signals at a point in the DND event loop
Date: Sat, 16 Apr 2022 23:21:25 -0400 [thread overview]
Message-ID: <jwvsfqc1jnh.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20220417003924.49D86C01684@vcs2.savannah.gnu.org> (Po Lu via Mailing list for Emacs changes's message of "Sat, 16 Apr 2022 20:39:24 -0400 (EDT)")
> @@ -9674,7 +9675,12 @@ x_dnd_begin_drag_and_drop (struct frame *f, Time time, Atom xaction,
> &next_event, &finish, &hold_quit);
> #endif
> #endif
> + /* The unblock_input below might try to read input, but
> + XTread_socket does nothing inside a drag-and-drop event
> + loop, so don't let it clear the pending_signals flag. */
> + signals_were_pending = pending_signals;
> unblock_input ();
> + pending_signals = signals_were_pending;
>
> if (x_dnd_movement_frame)
> {
This is pretty ugly.
Why is it that it "does nothing"? Any hope we can move this restoration
of `pending_signals` closer to the code that "does nothing"?
Stefan
next parent reply other threads:[~2022-04-17 3:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <165015596397.5558.5393619769224500857@vcs2.savannah.gnu.org>
[not found] ` <20220417003924.49D86C01684@vcs2.savannah.gnu.org>
2022-04-17 3:21 ` Stefan Monnier [this message]
2022-04-17 3:55 ` master 18ec3fcce9: Restore pending_signals at a point in the DND event loop Po Lu
2022-04-17 5:21 ` Stefan Monnier
2022-04-17 5:53 ` Po Lu
2022-04-20 15:05 ` Stefan Monnier
2022-04-21 0:29 ` Po Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvsfqc1jnh.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.