all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: dev@rjt.dev, Yuan Fu <casouri@gmail.com>,
	aqua0210@foxmail.com, 59498@debbugs.gnu.org, mardani29@yahoo.es
Subject: bug#59498: 29.0.50; c++-ts-mode get wrong-type-argument error when enabled
Date: Sun, 27 Nov 2022 02:18:06 -0500	[thread overview]
Message-ID: <jwvsfi4hnzi.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <83ilj0rk2y.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 27 Nov 2022 08:24:21 +0200")

>> I added treesit-comment-start/end to help indenting comments. So this is
>> the correct way to use them. The following comment explains why I created
>> new variables:
>> 
>> ;; `comment-start' and `comment-end' assume there is only one type of
>> ;; comment, and that the comment spans only one line.  So they are not
>> ;; sufficient for our purpose.
>
> ??? This is surprisingly unclean, IMO.  For starters, the names of the
> variables are confusing.  The need to define two sets of comment-start and
> comment-end regexps is also a nuisance and a source of errors.
>
> How do non-treesit modes handle this issue?  Why do the treesit-based modes
> need something special here?
>
> Stefan, any ideas?

`comment-start` and `comment-end` do not describe the set of possible
comment delimiters.  They describe the comment delimiters that should be
*inserted* when we do things like `comment-dwim`.

To find/match comment delimiters we have `comment-start-skip` and
`comment-end-skip`.  They're not ideal, but they've been good enough so far.
They don't say which comment starter matches which comment-ender (that
was done by the syntax-tables), but tree-sitter should be able to tell
us that when we need it.

It would be nice if we could avoid the need to set/use
`comment-start-skip` and `comment-end-skip` when using tree-sitter.
Maybe we can compute their values from the tree-sitter grammar.
But getting rid of uses of those vars will take a fair bit more work,
I think.


        Stefan






  reply	other threads:[~2022-11-27  7:18 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-23  2:24 bug#59498: 29.0.50; c++-ts-mode get wrong-type-argument error when enabled Eason Huang
2022-11-23  8:44 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-23 10:53   ` Eason Huang
2022-11-24 14:39     ` Randy Taylor
2022-11-25 12:56       ` Eason Huang
2022-11-26 11:18       ` Eli Zaretskii
2022-11-26 22:11         ` Yuan Fu
2022-11-27  6:24           ` Eli Zaretskii
2022-11-27  7:18             ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-11-27  7:24               ` Eli Zaretskii
2022-11-27 22:21                 ` Yuan Fu
2022-11-28  0:24                   ` Stefan Kangas
2022-12-18  9:57                     ` Eli Zaretskii
2022-12-18 22:49                       ` Yuan Fu
2022-12-19 13:51                         ` Eli Zaretskii
2022-12-20  1:56                           ` Yuan Fu
2022-12-20 15:18                             ` Eli Zaretskii
2022-12-21  0:37                               ` Yuan Fu
2022-11-28 13:59                   ` Eason Huang
2022-11-27 22:00               ` Yuan Fu
     [not found] <m24juq9zn6.fsf@foxmail.com>
2022-11-30 21:33 ` Yuan Fu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvsfi4hnzi.fsf-monnier+emacs@gnu.org \
    --to=bug-gnu-emacs@gnu.org \
    --cc=59498@debbugs.gnu.org \
    --cc=aqua0210@foxmail.com \
    --cc=casouri@gmail.com \
    --cc=dev@rjt.dev \
    --cc=eliz@gnu.org \
    --cc=mardani29@yahoo.es \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.