all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: 58921@debbugs.gnu.org, reza <reza@housseini.me>
Subject: bug#58921: Tab completion hangs in eshell
Date: Thu, 23 Feb 2023 13:08:36 -0500	[thread overview]
Message-ID: <jwvsfewfe7d.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <537afe67-809e-c09b-db84-05f41ba5d3b4@gmail.com> (Jim Porter's message of "Thu, 9 Feb 2023 23:34:52 -0800")

> @@ -304,36 +296,26 @@ pcomplete/tar
>         ((pcomplete-match "\\`--info-script=\\(.*\\)" 0)
>          (pcomplete-here* (pcomplete-entries)
>                           (pcomplete-match-string 1 0)))
> -       ((pcomplete-match "\\`--label=" 0)
> -        (pcomplete-here*))
> -       ((pcomplete-match "\\`--mode=" 0)
> -        (pcomplete-here*))
>         ((pcomplete-match "\\`--new-volume-script=\\(.*\\)" 0)
>          (pcomplete-here* (pcomplete-entries)
>                           (pcomplete-match-string 1 0)))
> -       ((pcomplete-match "\\`--newer=" 0)
> -        (pcomplete-here*))
>         ((pcomplete-match "\\`--owner=\\(.*\\)" 0)
>          (pcomplete-here* (pcmpl-unix-user-names)
>                           (pcomplete-match-string 1 0)))
> -       ((pcomplete-match "\\`--record-size=" 0)
> -        (pcomplete-here*))
>         ((pcomplete-match "\\`--rsh-command=\\(.*\\)" 0)
>          (pcomplete-here* (funcall pcomplete-command-completion-function)
>                           (pcomplete-match-string 1 0)))
>         ((pcomplete-match "\\`--starting-file=\\(.*\\)" 0)
>          (pcomplete-here* (pcomplete-entries)
>                           (pcomplete-match-string 1 0)))
> -       ((pcomplete-match "\\`--suffix=" 0)
> -        (pcomplete-here*))
> -       ((pcomplete-match "\\`--tape-length=" 0)
> -        (pcomplete-here*))
>         ((pcomplete-match "\\`--use-compress-program=\\(.*\\)" 0)
>          (pcomplete-here* (funcall pcomplete-command-completion-function)
>                           (pcomplete-match-string 1 0)))
>         ((pcomplete-match "\\`--volno-file=\\(.*\\)" 0)
>          (pcomplete-here* (pcomplete-entries)
> -                         (pcomplete-match-string 1 0)))))
> +                         (pcomplete-match-string 1 0)))
> +       ((pcomplete-match "\\`--.*=" 0)
> +        (pcomplete-here*))))
>      (unless saw-option
>        (pcomplete-here
>         (mapcar #'char-to-string

This looks good, but doesn't that still leave an inf-loop bug when the
input doesn't (pcomplete-match "\\`--.*=" 0)?


        Stefan






  parent reply	other threads:[~2023-02-23 18:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <2cb2b8aa-0813-5eae-3bfc-27831b3d50dd@housseini.me>
2022-10-31  9:04 ` bug#58921: Tab completion hangs in eshell reza via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-02  7:28   ` Gerd Möllmann
2023-02-10  7:34   ` Jim Porter
2023-02-23  6:57     ` Jim Porter
2023-02-23 18:08     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-02-23 19:25       ` Jim Porter
2023-02-23 19:34         ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-23 20:43           ` Jim Porter
2023-03-04  5:37             ` Jim Porter
2023-03-08 23:53               ` Jim Porter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvsfewfe7d.fsf-monnier+emacs@gnu.org \
    --to=bug-gnu-emacs@gnu.org \
    --cc=58921@debbugs.gnu.org \
    --cc=jporterbugs@gmail.com \
    --cc=monnier@iro.umontreal.ca \
    --cc=reza@housseini.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.