From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#68690: Segmentation fault building with native-comp Date: Thu, 25 Jan 2024 17:39:23 -0500 Message-ID: References: Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4731"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Gerd =?UTF-8?Q?M=C3=B6llmann?= , Eli Zaretskii , jm@pub.pink, 68690@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 25 23:40:15 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rT8OM-00010d-Ri for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 25 Jan 2024 23:40:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rT8O8-0004K9-3Q; Thu, 25 Jan 2024 17:40:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rT8O5-0004Jl-Ct for bug-gnu-emacs@gnu.org; Thu, 25 Jan 2024 17:39:57 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rT8O4-0004ml-Cd for bug-gnu-emacs@gnu.org; Thu, 25 Jan 2024 17:39:57 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rT8OA-0003sR-Eq for bug-gnu-emacs@gnu.org; Thu, 25 Jan 2024 17:40:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Jan 2024 22:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68690 X-GNU-PR-Package: emacs Original-Received: via spool by 68690-submit@debbugs.gnu.org id=B68690.170622237914858 (code B ref 68690); Thu, 25 Jan 2024 22:40:02 +0000 Original-Received: (at 68690) by debbugs.gnu.org; 25 Jan 2024 22:39:39 +0000 Original-Received: from localhost ([127.0.0.1]:49494 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rT8Nn-0003ra-GW for submit@debbugs.gnu.org; Thu, 25 Jan 2024 17:39:39 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:19296) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rT8Nl-0003rF-9U for 68690@debbugs.gnu.org; Thu, 25 Jan 2024 17:39:37 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 721FF4420FA; Thu, 25 Jan 2024 17:39:25 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1706222364; bh=+Jo540JlrW16NJ+59wDbgz4xXhi6mfd38N/OOwbD2Nk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=I9juwSgNUDYBFkEnbppByJqY2OCYdHkZqqPSGKmxnKPTJuauDfSa3fNvsE1ehmuJz HjmxnKyzAQ4LSM8gwi9O2xweDhrawKlwfDuPFUWd7qGk5Zb2NJJ7FuWQGPtpj755Yl FqNkMr/mVJXUaFIqQeBJ7N4W/ng3Jqm6vtnPQ5Q+s+ZAQo99d2trGMpyc1O5jwAmL4 2pEsJxkXA/zdrzcLhg1GAk/fcAlF/Is1HMKUzx6fW7ehg19xO7x7mQQLIi9rplz/dz TRuRBvoqZ21mEhUk9CNTT8wKjaHJXJ7w8g5jpwMa/8TWYTAhf830dT+DC3Itx8g9QB oSas5uyUvUWNA== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 3532E440874; Thu, 25 Jan 2024 17:39:24 -0500 (EST) Original-Received: from pastel (unknown [45.72.206.68]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 06C30120B52; Thu, 25 Jan 2024 17:39:24 -0500 (EST) In-Reply-To: ("Mattias =?UTF-8?Q?Engdeg=C3=A5rd?="'s message of "Thu, 25 Jan 2024 19:12:21 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:278872 Archived-At: > Sorry, my fault -- indeed maphash 'supports' irregular mutation in the sense > that it shouldn't crash or corrupt Emacs if the rules are violated. I can't > reproduce the reported crash(es) on my platform but is my understanding > correct that no other uses of DOHASH caused any trouble? AFAIK the current DOHASH code in `master` works fine (tho a bit ugly). The remaining build failure that Eli is seeing seems unrelated. > This patch reverts my last change to Fmaphash and yours to DOHASH. It's > perfectly fine to forego DOHASH in Fmaphash, it's chums with the hash-table > implementation. Assuming that the problems were confined to Fmaphash, this > should be safe to apply. The build failure didn't come via maphash` but via the DOHASH in `comp.c` that calls `compile_function` (which apparently can cause the hash table to be resized). So `maphash` is clearly not the only "offender". Stefan