read-file-name-internal changed

read-file-name-internal changed

[Tak Ota]

Some recent change, I suspect Stefan's change on 2005-03-28, modified
the behavior of read-file-name-internal which is called from ffap.el.
It used to return 

"//server/"

for

(read-file-name-internal "//server/" "c:/emacs/" nil)

but now it returns

"/server/"

This hinders to input network path on w32 platform.

-Tak

Re: read-file-name-internal changed

[Stefan Monnier]

> Some recent change, I suspect Stefan's change on 2005-03-28, modified
> the behavior of read-file-name-internal which is called from ffap.el.
> It used to return 

> "//server/"
> for
> (read-file-name-internal "//server/" "c:/emacs/" nil)

Hmm.... What does (substitute-in-file-name "//server/") return?


        Stefan

Re: read-file-name-internal changed

[Stefan Monnier]

>>>>> "Stefan" == Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> Some recent change, I suspect Stefan's change on 2005-03-28, modified
>> the behavior of read-file-name-internal which is called from ffap.el.
>> It used to return 

>> "//server/"
>> for
>> (read-file-name-internal "//server/" "c:/emacs/" nil)

> Hmm.... What does (substitute-in-file-name "//server/") return?

I see I got it, I've just installed the patch below which should fix
your problem.  Please confirm,
Than you,


        Stefan


Index: fileio.c
===================================================================
RCS file: /cvsroot/emacs/emacs/src/fileio.c,v
retrieving revision 1.534
diff -u -u -b -r1.534 fileio.c
--- fileio.c	28 Mar 2005 21:31:14 -0000	1.534
+++ fileio.c	30 Mar 2005 22:29:14 -0000
@@ -2078,7 +2078,7 @@
 #if defined (APOLLO) || defined (WINDOWSNT) || defined(CYGWIN)
 	  /* // at start of file name is meaningful in Apollo,
 	     WindowsNT and Cygwin systems.  */
-	  && !(IS_DIRECTORY_SEP (p[0]) && p - 1 != nm)
+	  && !(IS_DIRECTORY_SEP (p[0]) && p - 1 == nm)
 #endif /* not (APOLLO || WINDOWSNT || CYGWIN) */
 	      )
 	{

Re: read-file-name-internal changed

[Tak Ota]

Wed, 30 Mar 2005 14:24:50 -0800: "Stefan Monnier" <monnier@iro.umontreal.ca> wrote:

> > Some recent change, I suspect Stefan's change on 2005-03-28, modified
> > the behavior of read-file-name-internal which is called from ffap.el.
> > It used to return 
> 
> > "//server/"
> > for
> > (read-file-name-internal "//server/" "c:/emacs/" nil)
> 
> Hmm.... What does (substitute-in-file-name "//server/") return?
> 
> 
>         Stefan

That seems to be the culprit.

(substitute-in-file-name "//server/") returns

"/server/"

on 2005-03-29 built emacs while the same function returns

"//server/"

on 2005-03-21 built emacs.

-Tak

Re: read-file-name-internal changed

[Tak Ota]

I confirm that the problem is now fixed.  Thank you.

-Tak

Wed, 30 Mar 2005 14:33:45 -0800: "Stefan Monnier" <monnier@iro.umontreal.ca> wrote:

> >>>>> "Stefan" == Stefan Monnier <monnier@iro.umontreal.ca> writes:
> 
> >> Some recent change, I suspect Stefan's change on 2005-03-28, modified
> >> the behavior of read-file-name-internal which is called from ffap.el.
> >> It used to return 
> 
> >> "//server/"
> >> for
> >> (read-file-name-internal "//server/" "c:/emacs/" nil)
> 
> > Hmm.... What does (substitute-in-file-name "//server/") return?
> 
> I see I got it, I've just installed the patch below which should fix
> your problem.  Please confirm,
> Than you,
> 
> 
>         Stefan
> 
> 
> Index: fileio.c
> ===================================================================
> RCS file: /cvsroot/emacs/emacs/src/fileio.c,v
> retrieving revision 1.534
> diff -u -u -b -r1.534 fileio.c
> --- fileio.c	28 Mar 2005 21:31:14 -0000	1.534
> +++ fileio.c	30 Mar 2005 22:29:14 -0000
> @@ -2078,7 +2078,7 @@
>  #if defined (APOLLO) || defined (WINDOWSNT) || defined(CYGWIN)
>  	  /* // at start of file name is meaningful in Apollo,
>  	     WindowsNT and Cygwin systems.  */
> -	  && !(IS_DIRECTORY_SEP (p[0]) && p - 1 != nm)
> +	  && !(IS_DIRECTORY_SEP (p[0]) && p - 1 == nm)
>  #endif /* not (APOLLO || WINDOWSNT || CYGWIN) */
>  	      )
>  	{