From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Invalid use of Fmember in sigchld_handler Date: Mon, 12 Mar 2007 15:26:56 -0400 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1173727645 21335 80.91.229.12 (12 Mar 2007 19:27:25 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 12 Mar 2007 19:27:25 +0000 (UTC) Cc: emacs-devel@gnu.org To: Andreas Schwab Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Mar 12 20:27:19 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HQqAv-0005h9-8Q for ged-emacs-devel@m.gmane.org; Mon, 12 Mar 2007 20:27:17 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HQqBb-0003JK-Sw for ged-emacs-devel@m.gmane.org; Mon, 12 Mar 2007 14:27:59 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HQqBR-0003JF-4t for emacs-devel@gnu.org; Mon, 12 Mar 2007 15:27:49 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HQqBO-0003J3-Mf for emacs-devel@gnu.org; Mon, 12 Mar 2007 15:27:47 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HQqBO-0003J0-IH for emacs-devel@gnu.org; Mon, 12 Mar 2007 14:27:46 -0500 Original-Received: from mercure.iro.umontreal.ca ([132.204.24.67]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HQqAh-0002ct-BQ for emacs-devel@gnu.org; Mon, 12 Mar 2007 15:27:03 -0400 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 281792CEFA4; Mon, 12 Mar 2007 15:27:03 -0400 (EDT) Original-Received: from faina.iro.umontreal.ca (faina.iro.umontreal.ca [132.204.26.177]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id DB0433FE0; Mon, 12 Mar 2007 15:26:56 -0400 (EDT) Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id C7F0B6CB14; Mon, 12 Mar 2007 15:26:56 -0400 (EDT) In-Reply-To: (Andreas Schwab's message of "Mon\, 12 Mar 2007 17\:04\:22 +0100") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.93 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-detected-kernel: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:67811 Archived-At: > In sigchld_handler Fmember is used to find entries in deleted_pid_list, > but Fmember does not know about mark bits. >>From lisp.h: #ifndef XGCTYPE /* The distinction does not exist now that the MARKBIT has been eliminated. */ #define XGCTYPE(a) XTYPE (a) #endif The GC_foo macros shouldn't matter any more. I haven't removed them yet, because when I installed my "remove markbits" patch I wanted to keep changes to a minimum to ease acceptance, debugging, and maintenance, and afterwards it seemed too close to the release. Stefan PS: But of course the make_fixnum_or_float call was problematic, so this remark doesn't make any difference w.r.t the patch that Kim installed.