From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: doc-view cache file permissions Date: Wed, 31 Oct 2007 11:10:15 -0400 Message-ID: References: <7gk5p448xq.fsf@fencepost.gnu.org> <87wst33g0o.fsf@baldur.tsdh.de> <87pryv3eew.fsf@baldur.tsdh.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1193843468 29764 80.91.229.12 (31 Oct 2007 15:11:08 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 31 Oct 2007 15:11:08 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 31 16:11:11 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1InFDk-0000zZ-3R for ged-emacs-devel@m.gmane.org; Wed, 31 Oct 2007 16:11:08 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1InFDY-0008Bk-Vt for ged-emacs-devel@m.gmane.org; Wed, 31 Oct 2007 11:10:53 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1InFDX-0008Bf-56 for emacs-devel@gnu.org; Wed, 31 Oct 2007 11:10:51 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1InFDR-00089s-Em for emacs-devel@gnu.org; Wed, 31 Oct 2007 11:10:50 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1InFDR-00089k-9J for emacs-devel@gnu.org; Wed, 31 Oct 2007 11:10:45 -0400 Original-Received: from tomts10.bellnexxia.net ([209.226.175.54] helo=tomts10-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1InFDL-0002Pq-Ud for emacs-devel@gnu.org; Wed, 31 Oct 2007 11:10:45 -0400 Original-Received: from pastel.home ([74.12.208.145]) by tomts10-srv.bellnexxia.net (InterMail vM.5.01.06.13 201-253-122-130-113-20050324) with ESMTP id <20071031151015.RDBD1733.tomts10-srv.bellnexxia.net@pastel.home> for ; Wed, 31 Oct 2007 11:10:15 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 6C4FB7F9F; Wed, 31 Oct 2007 11:10:15 -0400 (EDT) In-Reply-To: <87pryv3eew.fsf@baldur.tsdh.de> (Tassilo Horn's message of "Wed\, 31 Oct 2007 08\:56\:55 +0100") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/23.0.50 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Solaris 8 (1) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:82219 Archived-At: > furthermore I noticed that `g' is bound twice in d-v-mode-map. I > changed the bindings so that `g' is bound to d-v-goto-page and `r' is > bound to d-v-reconvert-doc now. I understand that `r' (or `C-r') is often used by pdf viewers to refresh/reload, but `g' is the standard binding in Emacs for that, so I'd rather we keep `g' for `revert-buffer', add `r' that does the same, and then just use the standard M-g M-g binding to goto a specific page. Also I prefer `revert-buffer' because it also reverts the buffer's content rather than only the display. So I suggest the patch below instead, Stefan PS: I also think that C-S-n should be C-s and C-S-p should be C-r (but it's a bit more than just changing bindings and I haven't written the corresponding code). Index: doc-view.el =================================================================== RCS file: /sources/emacs/emacs/lisp/doc-view.el,v retrieving revision 1.15 diff -u -u -b -r1.15 doc-view.el --- doc-view.el 31 Oct 2007 03:10:32 -0000 1.15 +++ doc-view.el 31 Oct 2007 15:07:50 -0000 @@ -226,7 +226,7 @@ (define-key map (kbd "DEL") 'doc-view-scroll-down-or-previous-page) (define-key map (kbd "M-<") 'doc-view-first-page) (define-key map (kbd "M->") 'doc-view-last-page) - (define-key map (kbd "g") 'doc-view-goto-page) + (define-key map [remap goto-line] 'doc-view-goto-page) ;; Killing/burying the buffer (and the process) (define-key map (kbd "q") 'bury-buffer) (define-key map (kbd "k") 'doc-view-kill-proc-and-buffer) @@ -250,7 +250,8 @@ ;; Toggle between text and image display or editing (define-key map (kbd "C-c C-c") 'doc-view-toggle-display) ;; Reconvert the current document - (define-key map (kbd "g") 'doc-view-reconvert-doc) + (define-key map (kbd "g") 'revert-buffer) + (define-key map (kbd "r") 'revert-buffer) map) "Keymap used by `doc-view-mode' when displaying a doc as a set of images.")