From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: Re: compilation-next-error - extra `let' binding? Date: Sat, 09 Feb 2008 22:17:01 -0500 Message-ID: References: <005c01c86a82$3803b940$a350908d@us.oracle.com> <006301c86a83$570c67f0$a350908d@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1202613444 14042 80.91.229.12 (10 Feb 2008 03:17:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 10 Feb 2008 03:17:24 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org To: "Drew Adams" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 10 04:17:46 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JO2hL-0001lN-D7 for ged-emacs-devel@m.gmane.org; Sun, 10 Feb 2008 04:17:43 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JO2gs-0004TE-AW for ged-emacs-devel@m.gmane.org; Sat, 09 Feb 2008 22:17:14 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JO2gm-0004Qw-Vy for emacs-devel@gnu.org; Sat, 09 Feb 2008 22:17:09 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JO2gk-0004Ou-PT for emacs-devel@gnu.org; Sat, 09 Feb 2008 22:17:08 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JO2gk-0004Om-K1 for emacs-devel@gnu.org; Sat, 09 Feb 2008 22:17:06 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JO2gk-0005ZU-DI for emacs-devel@gnu.org; Sat, 09 Feb 2008 22:17:06 -0500 Original-Received: from mx10.gnu.org ([199.232.76.166]) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1JO2gk-0000AG-7F for emacs-pretest-bug@gnu.org; Sat, 09 Feb 2008 22:17:06 -0500 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1JO2gh-0005Z6-4L for emacs-pretest-bug@gnu.org; Sat, 09 Feb 2008 22:17:06 -0500 Original-Received: from ironport2-out.pppoe.ca ([206.248.154.182]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JO2gg-0005Z0-RM for emacs-pretest-bug@gnu.org; Sat, 09 Feb 2008 22:17:03 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AgAAAHr7rUfO+JwNdGdsb2JhbACQNgEwlxd7 X-IronPort-AV: E=Sophos;i="4.25,328,1199682000"; d="scan'208";a="13988639" Original-Received: from smtp.pppoe.ca ([65.39.196.238]) by ironport2-out.pppoe.ca with ESMTP; 09 Feb 2008 22:17:02 -0500 Original-Received: from pastel.home ([206.248.156.13]) by smtp.pppoe.ca (Internet Mail Server v1.0) with ESMTP id QFB22602; Sat, 09 Feb 2008 22:17:02 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id A92FB800F; Sat, 9 Feb 2008 22:17:01 -0500 (EST) In-Reply-To: <006301c86a83$570c67f0$a350908d@us.oracle.com> (Drew Adams's message of "Fri, 8 Feb 2008 10:49:30 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.50 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:88608 gmane.emacs.pretest.bugs:20974 Archived-At: > It also looks like the test in the second branch of this `if' could be just > (> n 0), for clarity: > (if (zerop n) > (unless ...) > (setq last (nth 2 (car msg))) > (if (>= n 0) ; <== Can't be zero here, anyway. > (compilation-loop ...) > ...)) Couldn't care less, Stefan