all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: rms@gnu.org
Cc: emacs-devel@gnu.org
Subject: Re: Strangeness in ASRT
Date: Sun, 10 Feb 2008 14:38:17 -0500	[thread overview]
Message-ID: <jwvr6fkfvs3.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <E1JOH84-0007Iz-Js@fencepost.gnu.org> (Richard Stallman's message of "Sun, 10 Feb 2008 13:42:16 -0500")

> This seems to have a bug which breaks compilation.
>     /* The IDX==IDX tries to detect when the macro argument is side-effecting.  */
>     #define ASET(ARRAY, IDX, VAL)	\
>       (eassert ((IDX) == (IDX)),				\
>        eassert ((IDX) >= 0 && (IDX) < ASIZE (ARRAY)),	\
>        ASLOT ((ARRAY), (IDX)) = (VAL))

> Changing ASLOT to AREF makes it compile.  (Bootstrapping still crashes
> as before.)

Oh, yes, it should be AREF, not ASLOT.  Sorry for the mixup.

> What is the purpose of these tests?  The expansion of AREF
> substitutes IDX only once, so there is no problem if it has
> a side effect.

If ENABLE_CHECKING is true, then eassert ((IDX) >= 0 && (IDX) < ASIZE
(ARRAY)) will cause IDX to be eval'd several times, so you'll get errors
when you set ENABLE_CHECKING and an argument has the form "index++".


        Stefan




      reply	other threads:[~2008-02-10 19:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-10 18:42 Strangeness in ASRT Richard Stallman
2008-02-10 19:38 ` Stefan Monnier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvr6fkfvs3.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.