From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: patch for optional inhibit of delete-other-windows(IDE feature) Date: Sun, 27 Apr 2008 21:20:21 -0400 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1209345638 31894 80.91.229.12 (28 Apr 2008 01:20:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 28 Apr 2008 01:20:38 +0000 (UTC) Cc: emacs-devel@gnu.org To: joakim@verona.se Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 28 03:21:14 2008 connect(): Connection refused Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JqI3N-0007dv-JB for ged-emacs-devel@m.gmane.org; Mon, 28 Apr 2008 03:21:13 +0200 Original-Received: from localhost ([127.0.0.1]:34461 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JqI2g-00075m-Pv for ged-emacs-devel@m.gmane.org; Sun, 27 Apr 2008 21:20:30 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JqI2c-00075O-2a for emacs-devel@gnu.org; Sun, 27 Apr 2008 21:20:26 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JqI2Z-000750-PY for emacs-devel@gnu.org; Sun, 27 Apr 2008 21:20:25 -0400 Original-Received: from [199.232.76.173] (port=57588 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JqI2Z-00074x-K7 for emacs-devel@gnu.org; Sun, 27 Apr 2008 21:20:23 -0400 Original-Received: from ironport2-out.pppoe.ca ([206.248.154.182] helo=ironport2-out.teksavvy.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JqI2Z-0000FI-8A for emacs-devel@gnu.org; Sun, 27 Apr 2008 21:20:23 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AuYCAFrDFEjO+IZzdGdsb2JhbACBU5AHASeXKQ X-IronPort-AV: E=Sophos;i="4.25,713,1199682000"; d="scan'208";a="19512042" Original-Received: from smtp.pppoe.ca (HELO smtp.teksavvy.com) ([65.39.196.238]) by ironport2-out.teksavvy.com with ESMTP; 27 Apr 2008 21:20:21 -0400 Original-Received: from pastel.home ([206.248.134.115]) by smtp.teksavvy.com (Internet Mail Server v1.0) with ESMTP id IFW97621; Sun, 27 Apr 2008 21:20:21 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 9D6AB8008; Sun, 27 Apr 2008 21:20:21 -0400 (EDT) In-Reply-To: (joakim@verona.se's message of "Sat, 26 Apr 2008 08:56:26 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:96034 Archived-At: >>> If the windows plist window-operation-behaviour-flags >>> delete-other-windows is t, the window is not electable for deletion when >>> delete-other-windows is run. >> >> I'd rather add window-parameter and set-window-parameter. After all, >> most objects have such things and it's useful for more than just >> "behavior flags". >> >> Such an addition is useful in general and can be installed right away. > Ok, I will model it like set-frame-parameter, frame-parameter. Thanks > for the tip! >> As for the introduction of special meaning for some parameters so as to >> influence delete-other-windows, while I think it may work well, I'd >> rather first see it fully developed and shown to be a good fit for ECB, >> before installing it. This is because there's a good chance that it may >> not work quite as needed at first and that the design requires some >> rounds of refinement until it's really what we want. > How do you feel about the current interface: > delete-other-windows t, inhibits delete-other-windows Honestly? I think it's terrible (it's just one-step better than using advice). But it's the best we have so far. What I hope to get from the above is an understand of which functions need to get changed together, then we can create a couple special window-parameter (call it "foo" and "bar"-windows) and have those handled accordingly in delete-other-windows, etc... The crucial difference is that "foo" and "bar" shouldn't have anything directly to do with delete-other-windows but should instead express a particular intention behind the use of the window. I.e. an attribute similar to `dedicated'. >> So I suggest you work on a separate branch for that. > I have set up a local bzr branch to work in, that should be enough right? Yes, that's fine. If you want to make it public, it's even better. Note also that I don't see any copyright assignment from you, so you may want to address this if you want to have your code installed (or if you want to place a mirror of your branch in Emacs's bzr repository). Stefan