Contradiction in Elisp page "File Local Variables"

Contradiction in Elisp page "File Local Variables"

[Alan Mackenzie]

Hi, Emacs!

On the Elisp page "File Local Variables", it says this about the setting
`:all' for `enable-local-variables':

    `:all'
          Set all the variables and do not query.
 
Lower down on the page, it defines `ignored-local-variables':

     This variable holds a list of variables that should not be given
     local values by files.  Any value specified for one of these
     variables is completely ignored.

The two compete with eachother.  The fine source code shows that
ignored-local-variables wins.  Here's a patch to fix it:



2008-06-13  Alan Mackenzie  <acm@muc.de>

	* variables.texi (File Local Variables): State that
	`ignored-local-variables' has a higher priority than `:all'.



*** variables.texi~	2008-06-13 11:14:38.347148200 +0000
--- variables.texi	2008-06-13 12:30:31.316991576 +0000
***************
*** 1553,1559 ****
  @item @code{:safe}
  Set only the safe variables and do not query.
  @item @code{:all}
! Set all the variables and do not query.
  @item @code{nil}
  Don't set any variables.
  @item anything else
--- 1553,1560 ----
  @item @code{:safe}
  Set only the safe variables and do not query.
  @item @code{:all}
! Set all the variables (except those in @code{ignored-local-variables})
! and do not query.
  @item @code{nil}
  Don't set any variables.
  @item anything else


Any objections to this patch?

-- 
Alan Mackenzie (Nuremberg, Germany).

Re: Contradiction in Elisp page "File Local Variables"

[Stefan Monnier]

> On the Elisp page "File Local Variables", it says this about the setting
> `:all' for `enable-local-variables':

>     `:all'
>           Set all the variables and do not query.
 
> Lower down on the page, it defines `ignored-local-variables':

>      This variable holds a list of variables that should not be given
>      local values by files.  Any value specified for one of these
>      variables is completely ignored.

> The two compete with eachother.  The fine source code shows that
> ignored-local-variables wins.  Here's a patch to fix it:

I guess your patch is OK, although I'd prefer a new wording that makes
it unnecessary to refer from one variable/value to the other.
E.g. if :all only said something along the lines of "Pretend the user
replies yes to all queries" [obviously that wording is bad, don't
bother shooting it down].


        Stefan