From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Adrian Robert <adrian.b.robert@gmail.com>
Cc: Dan Nicolaescu <dann@ics.uci.edu>, emacs- devel <emacs-devel@gnu.org>
Subject: Re: a review of the merge (Re: Emacs.app merged)
Date: Wed, 16 Jul 2008 23:43:07 -0400 [thread overview]
Message-ID: <jwvr69tp84q.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <D68874F1-3E18-41EC-9AFC-BC0EA5E91C19@gmail.com> (Adrian Robert's message of "Wed, 16 Jul 2008 21:25:34 -0400")
>> Why not just use admin/FOR-RELEASE? It's easier to look in just one place.
> This is up to the maintainers. I thought while the port is settling down
> and there are a lot of issues, it might be good to keep them from
> cluttering up the admin file.
Actually, I think it can be placed into admin/FOR-RELEASE. Thanks to
the outline mode, anybody bothered by this Emacs.app section can fold it
away from view ;-)
> Actually, the Carbon and Windows ports put these defs in source code,
> macfns.c and w32fns.c respectively. Keeping them in a separate data file
> seems a little cleaner, and also fits well with the way color lists are
> handled in NeXTstep. But the defs can be moved into source code if that
> is preferred.
I have no preference, except that merging them into a single file sounds
like a good idea (to the extent possible, obviously: I haven't looked
at it at all).
> This is so users can enter colors in numeric format, such as ARGBD0FFFFFF.
> The NS port interprets such formats to allow alpha specification.
Can't similar "uncompletable colors" be specified in X11 (with format
"#RRGGBB" or somesuch)? Maybe your change should be applied to
more platforms?
In any case, we need a comment in that code to explain why
`require-match' is set or not, and when.
> This is not done by default, only when ns-extended-platform-support is
> turned on. And it makes only very minor modifications, for purpose of
> enhancing platform consistency. Anyway, if this is retained, one option
> would be to move it out into a separately-loaded file (not included in
> dumped emacs). Another would be to manually do what easymenu does (but
> this would be ugly).
Maybe a separate file would be a good choice. Better yet: make it work
(as much as possible) for non-NS platforms as well, in case someone used
to those modifications wants to use them under w32, X11, ...
> Here I aped what the Carbon port does just above these lines. If it's
> wrong, which example should I follow?
The dependencies seem harmless for other platforms, so you can just
remove the #ifdef. Any removal of CPP tricks in src/Makefile.in is
good, since it gets us one step closer to the point where we can get rid
of the cpp processing step.
>> Index: src/frame.c
>> ...
>> Fselect_window (XFRAME (frame)->selected_window, Qnil);
>>
>> +#ifdef NS_IMPL_COCOA
>> + /* term gets no other notification of this */
>> + if (for_deletion)
>> + Fraise_frame(Qnil);
>> +#endif
>>
>> Why isn't his needed for other platforms too?
> I don't know. I would be happy to get rid of it if I knew.
Please explain as precisely as you can what is the problem you're trying
to solve with the above code.
> Are there other options besides FIXME? I use PENDING to flag something that
> is not necessarily a bug or even needing change, but that needs to be
> considered. What about TODO?
I use FIXME for those as well.
> Yes, I was working to make this only happen when ns-extended-platform-
> support-mode is on, but it's a bit tricky since this only gets called once.
With the new where-is-preferred-modifier, this should now be easier.
> Yes, hash_put, hash_remove, etc. are all used in those libs.
> Only hash_remove is declared so publicly within emacs though.
Actually, I see hash_remove in lisp.h, but it seems not to be used
outside of fns.c so it should probably be made static.
Stefan
next prev parent reply other threads:[~2008-07-17 3:43 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-15 18:47 Emacs.app merged Adrian Robert
2008-07-15 18:49 ` İsmail Dönmez
2008-07-15 19:28 ` Chong Yidong
2008-07-15 22:32 ` Thomas Christensen
2008-07-15 23:29 ` Cezar Halmagean
2008-07-16 9:25 ` a review of the merge (Re: Emacs.app merged) Dan Nicolaescu
2008-07-16 10:00 ` Jason Rumney
2008-07-16 12:17 ` Adrian Robert
2008-07-16 16:15 ` Stefan Monnier
2008-07-16 16:21 ` Stefan Monnier
2008-07-16 21:23 ` Dan Nicolaescu
2008-07-20 1:27 ` Adrian Robert
2008-07-20 11:56 ` Dan Nicolaescu
2008-07-28 13:25 ` Adrian Robert
2008-07-28 19:00 ` Dan Nicolaescu
2008-08-01 10:48 ` Adrian Robert
2008-08-01 11:09 ` Jason Rumney
2008-08-01 12:55 ` Dan Nicolaescu
2008-08-01 13:36 ` Eli Zaretskii
2008-08-01 13:49 ` Jason Rumney
2008-08-01 14:23 ` Dan Nicolaescu
2008-08-01 14:48 ` Adrian Robert
2008-08-01 15:07 ` Dan Nicolaescu
2008-07-17 1:25 ` Adrian Robert
2008-07-17 3:24 ` Dan Nicolaescu
2008-07-17 4:16 ` FOR-RELEASE [was Re: a review of the merge (Re: Emacs.app merged)] Glenn Morris
2008-07-17 4:19 ` a review of the merge (Re: Emacs.app merged) Glenn Morris
2008-07-17 17:22 ` Adrian Robert
2008-07-17 18:08 ` Dan Nicolaescu
2008-07-17 3:43 ` Stefan Monnier [this message]
2008-07-17 7:33 ` David De La Harpe Golden
2008-07-17 6:55 ` Dan Nicolaescu
2008-07-16 19:26 ` Emacs.app merged Stefan Monnier
2008-07-17 1:26 ` Adrian Robert
2008-07-27 20:12 ` some missing code? (was: Re: Emacs.app merged) Dan Nicolaescu
2008-07-27 22:18 ` observations for ns*.m files (Re: " Dan Nicolaescu
2008-07-28 1:54 ` Adrian Robert
2008-07-28 2:58 ` Dan Nicolaescu
2008-07-28 4:16 ` Stefan Monnier
2008-07-28 11:00 ` Miles Bader
2008-07-28 7:15 ` Jason Rumney
2008-07-28 13:29 ` Adrian Robert
2008-07-28 13:54 ` Chong Yidong
2008-07-28 15:10 ` Jason Rumney
2008-07-28 13:28 ` Adrian Robert
2008-07-28 14:35 ` Dan Nicolaescu
2008-08-05 5:13 ` build system observations (was " Dan Nicolaescu
2008-08-06 16:25 ` Adrian Robert
2008-08-06 17:29 ` build system observations Dan Nicolaescu
2008-08-07 1:36 ` Adrian Robert
2008-09-05 15:03 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvr69tp84q.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=adrian.b.robert@gmail.com \
--cc=dann@ics.uci.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.