* Get rid of per-frame settings of faces via Xresources
@ 2009-05-04 20:25 Stefan Monnier
2009-05-05 0:04 ` Samuel Bronson
2009-05-05 0:21 ` David Reitter
0 siblings, 2 replies; 5+ messages in thread
From: Stefan Monnier @ 2009-05-04 20:25 UTC (permalink / raw
To: emacs-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Get rid of per-frame settings of faces via Xresources
2009-05-04 20:25 Get rid of per-frame settings of faces via Xresources Stefan Monnier
@ 2009-05-05 0:04 ` Samuel Bronson
2009-05-05 3:35 ` Stefan Monnier
2009-05-05 0:21 ` David Reitter
1 sibling, 1 reply; 5+ messages in thread
From: Samuel Bronson @ 2009-05-05 0:04 UTC (permalink / raw
To: Stefan Monnier; +Cc: emacs-devel
On Mon, May 4, 2009 at 4:25 PM, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>
>
>
How very interesting!
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Get rid of per-frame settings of faces via Xresources
2009-05-04 20:25 Get rid of per-frame settings of faces via Xresources Stefan Monnier
2009-05-05 0:04 ` Samuel Bronson
@ 2009-05-05 0:21 ` David Reitter
2009-05-05 1:19 ` Chong Yidong
1 sibling, 1 reply; 5+ messages in thread
From: David Reitter @ 2009-05-05 0:21 UTC (permalink / raw
To: Stefan Monnier; +Cc: emacs-devel
Well, the subject line was informative enough.
If I interpret you correctly: We've had (some of) that removed in
Aquamacs (back then based on pre Emacs 22.1 code) simply because frame
creation was slowed down tremendously (seconds!) when many faces were
known to Emacs (as is the case when you use color themes and you try
out a bunch of them during the session). I decided not to support X
resources on the Mac (under Carbon) - I don't think anybody missed
it. ]
I'm not sure about X of course.
*** lisp/faces.el 13 Apr 2007 18:24:53 +0100 1.370
--- lisp/faces.el 13 Jul 2007 18:56:06 +0100
***************
*** 320,326 ****
(defun set-face-attributes-from-resources (face frame)
"Set attributes of FACE from X resources for FRAME."
! (when (memq (framep frame) '(x w32 mac))
(dolist (definition face-x-resources)
(let ((attribute (car definition)))
(dolist (entry (cdr definition))
--- 320,326 ----
(defun set-face-attributes-from-resources (face frame)
"Set attributes of FACE from X resources for FRAME."
! (when (eq (framep frame) 'x)
(dolist (definition face-x-resources)
(let ((attribute (car definition)))
(dolist (entry (cdr definition))
***************
*** 1789,1796 ****
(condition-case ()
(progn
(face-spec-set face (face-user-default-spec face) frame)
! (if (memq window-system '(x w32 mac))
! (make-face-x-resource-internal face frame))
(internal-merge-in-global-face face frame))
(error nil)))
;; Apply the attributes specified by frame parameters. This
--- 1789,1796 ----
(condition-case ()
(progn
(face-spec-set face (face-user-default-spec face) frame)
! (if (eq window-system 'x)
! (make-face-x-resource-internal face frame))
(internal-merge-in-global-face face frame))
(error nil)))
;; Apply the attributes specified by frame parameters. This
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Get rid of per-frame settings of faces via Xresources
2009-05-05 0:21 ` David Reitter
@ 2009-05-05 1:19 ` Chong Yidong
0 siblings, 0 replies; 5+ messages in thread
From: Chong Yidong @ 2009-05-05 1:19 UTC (permalink / raw
To: David Reitter; +Cc: Stefan Monnier, emacs-devel
David Reitter <david.reitter@gmail.com> writes:
> Well, the subject line was informative enough.
>
> If I interpret you correctly: We've had (some of) that removed in
> Aquamacs (back then based on pre Emacs 22.1 code) simply because frame
> creation was slowed down tremendously (seconds!) when many faces were
> known to Emacs (as is the case when you use color themes and you try
> out a bunch of them during the session). I decided not to support X
> resources on the Mac (under Carbon) - I don't think anybody missed
> it. ]
>
> I'm not sure about X of course.
We can't do anything about this right now. Please file a bug if you
want this to be considered after the release.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Get rid of per-frame settings of faces via Xresources
2009-05-05 0:04 ` Samuel Bronson
@ 2009-05-05 3:35 ` Stefan Monnier
0 siblings, 0 replies; 5+ messages in thread
From: Stefan Monnier @ 2009-05-05 3:35 UTC (permalink / raw
To: Samuel Bronson; +Cc: emacs-devel
>>>>> "Samuel" == Samuel Bronson <naesten@gmail.com> writes:
> On Mon, May 4, 2009 at 4:25 PM, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>>
> How very interesting!
Oops, it wasn't meant for the list, sorry,
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-05-05 3:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-04 20:25 Get rid of per-frame settings of faces via Xresources Stefan Monnier
2009-05-05 0:04 ` Samuel Bronson
2009-05-05 3:35 ` Stefan Monnier
2009-05-05 0:21 ` David Reitter
2009-05-05 1:19 ` Chong Yidong
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.