From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Carsten Bormann <cabo@tzi.org>
Cc: emacs-pretest-bug@gnu.org, 4933@emacsbugs.donarmstrong.com
Subject: bug#4933: 23.1.50; RCS buffer: save-buffer moves point to beginning of buffer
Date: Mon, 16 Nov 2009 09:41:17 -0500 [thread overview]
Message-ID: <jwvr5ry8rea.fsf-monnier+emacsbugreports@gnu.org> (raw)
In-Reply-To: <D4A7BA83-41AC-44D9-BC36-6962A994F628@tzi.org> (Carsten Bormann's message of "Mon, 16 Nov 2009 06:38:26 +0100")
> Start Emacs with -Q -q.
> C-x C-f a file with an RCS version control file behind it.
> perform some edit somewhere.
> C-x C-s.
> Bug: Point does not stay where it was, but jumps to the beginning of the file.
> (Note that this does not seem to occur with, e.g., svn-controlled files.)
Thank you for that precise bug report. I've just installed the patch
below which should fix it,
Stefan
--- vc-rcs.el.~1.97.~ 2009-11-15 23:34:56.000000000 -0500
+++ vc-rcs.el 2009-11-16 09:38:57.000000000 -0500
@@ -1056,6 +1056,7 @@
((not (get-file-buffer file)) nil)
((let (status version locking-user)
(with-current-buffer (get-file-buffer file)
+ (save-excursion
(goto-char (point-min))
(cond
;; search for $Id or $Header
@@ -1112,7 +1113,7 @@
(setq status 'rev)))
;; else: nothing found
;; -------------------
- (t nil)))
+ (t nil))))
(if status (vc-file-setprop file 'vc-working-revision version))
(and (eq status 'rev-and-lock)
(vc-file-setprop file 'vc-state
next prev parent reply other threads:[~2009-11-16 14:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <jwvmy2m7ajn.fsf-monnier+emacsbugreports@gnu.org>
2009-11-16 5:38 ` bug#4933: 23.1.50; RCS buffer: save-buffer moves point to beginning of buffer Carsten Bormann
2009-11-16 14:41 ` Stefan Monnier [this message]
2009-11-16 14:54 ` Carsten Bormann
2009-11-16 19:45 ` bug#4933: marked as done (23.1.50; RCS buffer: save-buffer moves point to beginning of buffer) Emacs bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvr5ry8rea.fsf-monnier+emacsbugreports@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=4933@emacsbugs.donarmstrong.com \
--cc=cabo@tzi.org \
--cc=emacs-pretest-bug@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.