From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Dired auto-revert Date: Thu, 03 Dec 2009 21:15:31 -0500 Message-ID: References: <87hbv6gel6.fsf@gmail.com> <87iqfhbo6u.fsf@mail.jurta.org> <87iqfc2fy1.fsf_-_@mail.jurta.org> <87skbr61n6.fsf@mail.jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1259892951 9985 80.91.229.12 (4 Dec 2009 02:15:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 4 Dec 2009 02:15:51 +0000 (UTC) Cc: Drew Adams , emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 04 03:15:44 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NGNhv-0003y9-GA for ged-emacs-devel@m.gmane.org; Fri, 04 Dec 2009 03:15:43 +0100 Original-Received: from localhost ([127.0.0.1]:45327 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NGNhv-0001e3-2G for ged-emacs-devel@m.gmane.org; Thu, 03 Dec 2009 21:15:43 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NGNho-0001c1-TN for emacs-devel@gnu.org; Thu, 03 Dec 2009 21:15:36 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NGNhk-0001aQ-WF for emacs-devel@gnu.org; Thu, 03 Dec 2009 21:15:36 -0500 Original-Received: from [199.232.76.173] (port=44576 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NGNhk-0001aN-Py for emacs-devel@gnu.org; Thu, 03 Dec 2009 21:15:32 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:49903 helo=ironport2-out.pppoe.ca) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NGNhk-0004C7-JO for emacs-devel@gnu.org; Thu, 03 Dec 2009 21:15:32 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArEEADb/F0tFpZ1E/2dsb2JhbACBTtRMhDIEihk X-IronPort-AV: E=Sophos;i="4.47,339,1257138000"; d="scan'208";a="50654606" Original-Received: from 69-165-157-68.dsl.teksavvy.com (HELO pastel.home) ([69.165.157.68]) by ironport2-out.pppoe.ca with ESMTP; 03 Dec 2009 21:15:32 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id EB38D86C4; Thu, 3 Dec 2009 21:15:31 -0500 (EST) In-Reply-To: <87skbr61n6.fsf@mail.jurta.org> (Juri Linkov's message of "Fri, 04 Dec 2009 02:09:17 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:118225 Archived-At: > This patch provides a defcustom that allows specifying a predicate function > for anyone who wants a non-standard auto-reverting. By default it is nil > preserving the current behavior. Looks OK, except for the little docstring nitpick below: > +If its value is a predicate function that checks if directory has > +changed on disk, call this function with the directory name argument > +and revert the buffer if it returns non-nil. There's no way the code can check whether the value is "a predicate function that checks if directory has changed on disk" (it's one of those halting-problem-equivalent). So really it should just say If its value is a function, call this function with the directory name as single argument and revert the buffer if it returns non-nil. -- Stefan