From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#8304: 23.2; ad-read-advised-function default to func at point Date: Mon, 21 Mar 2011 10:40:38 -0400 Message-ID: References: <87bp1573ka.fsf@blah.blah> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1300720090 27083 80.91.229.12 (21 Mar 2011 15:08:10 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 21 Mar 2011 15:08:10 +0000 (UTC) Cc: 8304@debbugs.gnu.org To: Kevin Ryde Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Mar 21 16:08:04 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Q1giC-0008Bx-4U for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Mar 2011 16:08:04 +0100 Original-Received: from localhost ([127.0.0.1]:50773 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q1giA-0007Ut-EA for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Mar 2011 11:08:02 -0400 Original-Received: from [140.186.70.92] (port=51896 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q1ghI-0006t4-H5 for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2011 11:07:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q1ghG-0001XI-G0 for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2011 11:07:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:52366) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q1ghG-0001XB-Ay for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2011 11:07:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Q1gI1-0006zT-ON; Mon, 21 Mar 2011 10:41:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Mar 2011 14:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8304 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 8304-submit@debbugs.gnu.org id=B8304.130071844626846 (code B ref 8304); Mon, 21 Mar 2011 14:41:01 +0000 Original-Received: (at 8304) by debbugs.gnu.org; 21 Mar 2011 14:40:46 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q1gHm-0006yx-0w for submit@debbugs.gnu.org; Mon, 21 Mar 2011 10:40:46 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q1gHk-0006yh-Ej; Mon, 21 Mar 2011 10:40:45 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEAOP/hk1Ld/X5/2dsb2JhbAClcnjAIYVjBJVp X-IronPort-AV: E=Sophos;i="4.63,219,1299474000"; d="scan'208";a="97411613" Original-Received: from 75-119-245-249.dsl.teksavvy.com (HELO pastel.home) ([75.119.245.249]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 21 Mar 2011 10:40:38 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 7099758AF5; Mon, 21 Mar 2011 10:40:38 -0400 (EDT) In-Reply-To: <87bp1573ka.fsf@blah.blah> (Kevin Ryde's message of "Mon, 21 Mar 2011 10:52:21 +1100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 21 Mar 2011 10:41:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:45228 Archived-At: > * emacs-lisp/advice.el (ad-read-advised-function): Use > `function-called-at-point' as the default default, if the func at > point has advice, and passes PREDICATE. Sounds like a fine change. > -plays the same role as for `try-completion' (which see). DEFAULT will > -be returned on empty input (defaults to the first advised function for > -which PREDICATE returns non-nil)." > +plays the same role as for `try-completion' (which see). > + > +DEFAULT is returned on empty input. DEFAULT defaults to the > +function name at point if it's advised and passes PREDICATE, > +otherwise to the first advised function which passes PREDICATE." Actually, I don't think the docstring should document what `default' will default to. Actually, AFAICT the `default' argument is never used. > + ;; prefer func name at point, if it's in ad-advised-functions etc Comments should start with a capital and end with a "." or some other appropriate punctuation. Stefan