From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Kevin Ryde <user42@zip.com.au>
Cc: 8304@debbugs.gnu.org
Subject: bug#8304: 23.2; ad-read-advised-function default to func at point
Date: Mon, 21 Mar 2011 10:40:38 -0400 [thread overview]
Message-ID: <jwvr5a01qvl.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87bp1573ka.fsf@blah.blah> (Kevin Ryde's message of "Mon, 21 Mar 2011 10:52:21 +1100")
> * emacs-lisp/advice.el (ad-read-advised-function): Use
> `function-called-at-point' as the default default, if the func at
> point has advice, and passes PREDICATE.
Sounds like a fine change.
> -plays the same role as for `try-completion' (which see). DEFAULT will
> -be returned on empty input (defaults to the first advised function for
> -which PREDICATE returns non-nil)."
> +plays the same role as for `try-completion' (which see).
> +
> +DEFAULT is returned on empty input. DEFAULT defaults to the
> +function name at point if it's advised and passes PREDICATE,
> +otherwise to the first advised function which passes PREDICATE."
Actually, I don't think the docstring should document what `default' will
default to. Actually, AFAICT the `default' argument is never used.
> + ;; prefer func name at point, if it's in ad-advised-functions etc
Comments should start with a capital and end with a "." or some other
appropriate punctuation.
Stefan
next prev parent reply other threads:[~2011-03-21 14:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-20 23:52 bug#8304: 23.2; ad-read-advised-function default to func at point Kevin Ryde
2011-03-21 14:40 ` Stefan Monnier [this message]
2011-05-22 0:29 ` Kevin Ryde
2011-05-23 14:40 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvr5a01qvl.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=8304@debbugs.gnu.org \
--cc=user42@zip.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.