From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#8942: 23.3; emacsclient doesn't exit when called Emacs function is quited. Date: Mon, 04 Jul 2011 14:43:31 -0400 Message-ID: References: <87d3hzpqcj.dlv@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1309805066 6203 80.91.229.12 (4 Jul 2011 18:44:26 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 4 Jul 2011 18:44:26 +0000 (UTC) Cc: Remi Vanicat , 8942@debbugs.gnu.org To: Juanma Barranquero Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 04 20:44:21 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Qdo83-0002rR-PI for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Jul 2011 20:44:19 +0200 Original-Received: from localhost ([::1]:37349 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qdo82-0000Q8-Vp for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Jul 2011 14:44:19 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:42899) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qdo7o-0000Pp-3j for bug-gnu-emacs@gnu.org; Mon, 04 Jul 2011 14:44:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qdo7m-0007kU-T2 for bug-gnu-emacs@gnu.org; Mon, 04 Jul 2011 14:44:03 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49085) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qdo7m-0007kQ-Rb for bug-gnu-emacs@gnu.org; Mon, 04 Jul 2011 14:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Qdo7m-0002rS-7b; Mon, 04 Jul 2011 14:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Jul 2011 18:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8942 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 8942-submit@debbugs.gnu.org id=B8942.130980502010964 (code B ref 8942); Mon, 04 Jul 2011 18:44:02 +0000 Original-Received: (at 8942) by debbugs.gnu.org; 4 Jul 2011 18:43:40 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qdo7P-0002qn-R8 for submit@debbugs.gnu.org; Mon, 04 Jul 2011 14:43:40 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.183] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qdo7N-0002qX-No for 8942@debbugs.gnu.org; Mon, 04 Jul 2011 14:43:38 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAEYJEk5FxIxr/2dsb2JhbABTp3t4iHrBJoY2BJ5chCw X-IronPort-AV: E=Sophos;i="4.65,474,1304308800"; d="scan'208";a="120405116" Original-Received: from 69-196-140-107.dsl.teksavvy.com (HELO pastel.home) ([69.196.140.107]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 04 Jul 2011 14:43:32 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id E213358DBA; Mon, 4 Jul 2011 14:43:31 -0400 (EDT) In-Reply-To: (Juanma Barranquero's message of "Mon, 4 Jul 2011 20:06:24 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 04 Jul 2011 14:44:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:47979 Archived-At: >> So if you want to remove with-local-quit, you need to add a let-binding >> of inhibit-quit to nil within your condition-case. > No, I don't have a particular interest in removing with-local-quit. As > I said, this > === modified file 'lisp/server.el' > --- lisp/server.el 2011-07-04 01:04:29 +0000 > +++ lisp/server.el 2011-07-04 18:04:02 +0000 > @@ -1153,7 +1153,7 @@ > "When done with a buffer, type > \\[server-edit]"))))) > (when (and frame (null tty-name)) > (server-unselect-display frame))) > - (error (server-return-error proc err))))) > + ((error quit) (server-return-error proc err))))) > (defun server-return-error (proc err) > (ignore-errors > is more than enough to fix the bug. Good. > The question is if you still want to show the user some feedback about > the fact that he quit the emacsclient eval, and how to do so. Ah, yes, that could be useful. > (message "Quit") perhaps? :-) OK, although we could also be a bit more informative that the quit interrupted an emacsclient command, like "Quit emacsclient request". Stefan