all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: Remi Vanicat <vanicat@debian.org>, 8942@debbugs.gnu.org
Subject: bug#8942: 23.3; emacsclient doesn't exit when called Emacs function is quited.
Date: Mon, 04 Jul 2011 14:43:31 -0400	[thread overview]
Message-ID: <jwvr5656g96.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CAAeL0SRe0X3Saer_13BUYryRqEdJRTa275TiWf4dtrXtw0h1GQ@mail.gmail.com> (Juanma Barranquero's message of "Mon, 4 Jul 2011 20:06:24 +0200")

>> So if you want to remove with-local-quit, you need to add a let-binding
>> of inhibit-quit to nil within your condition-case.

> No, I don't have a particular interest in removing with-local-quit. As
> I said, this

> === modified file 'lisp/server.el'
> --- lisp/server.el      2011-07-04 01:04:29 +0000
> +++ lisp/server.el      2011-07-04 18:04:02 +0000
> @@ -1153,7 +1153,7 @@
>                               "When done with a buffer, type
> \\[server-edit]")))))
>            (when (and frame (null tty-name))
>              (server-unselect-display frame)))
> -      (error (server-return-error proc err)))))
> +      ((error quit) (server-return-error proc err)))))

>  (defun server-return-error (proc err)
>    (ignore-errors


> is more than enough to fix the bug.

Good.

> The question is if you still want to show the user some feedback about
> the fact that he quit the emacsclient eval, and how to do so.

Ah, yes, that could be useful.

> (message "Quit") perhaps? :-)

OK, although we could also be a bit more informative that the quit
interrupted an emacsclient command, like "Quit emacsclient request".


        Stefan





  reply	other threads:[~2011-07-04 18:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-27  9:37 bug#8942: 23.3; emacsclient doesn't exit when called Emacs function is quited Remi Vanicat
2011-07-04  9:33 ` Juanma Barranquero
2011-07-04 14:32   ` Stefan Monnier
2011-07-04 14:41     ` Juanma Barranquero
2011-07-04 17:57       ` Stefan Monnier
2011-07-04 18:06         ` Juanma Barranquero
2011-07-04 18:43           ` Stefan Monnier [this message]
2011-07-04 22:40             ` Juanma Barranquero

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvr5656g96.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=8942@debbugs.gnu.org \
    --cc=lekktu@gmail.com \
    --cc=vanicat@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.