From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#9160: 24.0.50; Emacs freezes in *shell* buffer. Date: Sun, 28 Aug 2011 01:16:37 -0400 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1314508640 3221 80.91.229.12 (28 Aug 2011 05:17:20 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 28 Aug 2011 05:17:20 +0000 (UTC) Cc: 9160@debbugs.gnu.org To: Kenichi Handa Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 28 07:17:16 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QxXkB-0007KM-HI for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Aug 2011 07:17:15 +0200 Original-Received: from localhost ([::1]:44954 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QxXkA-0001xg-0q for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Aug 2011 01:17:14 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:35178) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QxXk6-0001xZ-IO for bug-gnu-emacs@gnu.org; Sun, 28 Aug 2011 01:17:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QxXk5-0001sI-Bt for bug-gnu-emacs@gnu.org; Sun, 28 Aug 2011 01:17:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59219) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QxXk5-0001sE-6r for bug-gnu-emacs@gnu.org; Sun, 28 Aug 2011 01:17:09 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QxXms-00021P-98; Sun, 28 Aug 2011 01:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Aug 2011 05:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9160 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 9160-submit@debbugs.gnu.org id=B9160.13145087787740 (code B ref 9160); Sun, 28 Aug 2011 05:20:02 +0000 Original-Received: (at 9160) by debbugs.gnu.org; 28 Aug 2011 05:19:38 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QxXmT-00020n-Uq for submit@debbugs.gnu.org; Sun, 28 Aug 2011 01:19:38 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.183] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QxXmQ-00020e-FF for 9160@debbugs.gnu.org; Sun, 28 Aug 2011 01:19:35 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EANHNWU5MCpTr/2dsb2JhbAA5CagOeIFAAQEEAVYjBQsLNBIUGA0kE4dytkKDKYMjBKADhDw X-IronPort-AV: E=Sophos;i="4.68,292,1312171200"; d="scan'208";a="133188560" Original-Received: from 76-10-148-235.dsl.teksavvy.com (HELO ceviche.home) ([76.10.148.235]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 28 Aug 2011 01:16:37 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id A8555660CF; Sun, 28 Aug 2011 01:16:37 -0400 (EDT) In-Reply-To: (Kenichi Handa's message of "Thu, 25 Aug 2011 09:52:49 +0900") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sun, 28 Aug 2011 01:20:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:50384 Archived-At: > Thank you I confirmed that the above test case now works. > But, found another bug. If I use `rm' command instead of > `ls': > % rm 0\ TAB > the completion doesn't work and I just see a message "No > match". If there's not space after the backslash, then that's a bug that's already in Emacs-23, and I don't know yet how to fix it. When there is a space after the backslash, we indeed have a bug and I think I've fixed it with the patch below. Stefan === modified file 'lisp/ChangeLog' --- lisp/ChangeLog 2011-08-27 08:41:23 +0000 +++ lisp/ChangeLog 2011-08-28 05:14:29 +0000 @@ -1,3 +1,7 @@ +2011-08-28 Stefan Monnier + + * shell.el (shell-parse-pcomplete-arguments): Unquote args (bug#9160). + 2011-08-27 Alan Mackenzie * progmodes/cc-menus.el (cc-imenu-c++-generic-expression): Make it === modified file 'lisp/shell.el' --- lisp/shell.el 2011-08-23 05:25:17 +0000 +++ lisp/shell.el 2011-08-28 04:21:05 +0000 @@ -393,10 +393,28 @@ (while (< (point) end) (skip-chars-forward " \t\n") (push (point) begins) - (looking-at "\\(?:[^\s\t\n\\]\\|'[^']*'\\|\"\\(?:[^\"\\]\\|\\\\.\\)*\"\\|\\\\.\\)*\\(?:\\\\\\|'[^']*\\|\"\\(?:[^\"\\]\\|\\\\.\\)*\\)?") + (let ((arg ())) + (while (looking-at + (eval-when-compile + (concat + "\\(?:[^\s\t\n\\\"']+" + "\\|'\\([^']*\\)'?" + "\\|\"\\(\\(?:[^\"\\]\\|\\\\.\\)*\\)\"?" + "\\|\\\\\\(\\(?:.\\|\n\\)?\\)\\)"))) (goto-char (match-end 0)) - (push (buffer-substring-no-properties (car begins) (point)) - args)) + (cond + ((match-beginning 3) ;Backslash escape. + (push (if (= (match-beginning 3) (match-end 3)) + "\\" (match-string 3)) + arg)) + ((match-beginning 2) ;Double quote. + (push (replace-regexp-in-string + "\\\\\\(.\\)" "\\1" (match-string 2)) + arg)) + ((match-beginning 1) ;Single quote. + (push (match-string 1) arg)) + (t (push (match-string 0) arg)))) + (push (mapconcat #'identity (nreverse arg) "") args))) (cons (nreverse args) (nreverse begins))))) (defun shell-completion-vars ()