From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#2224: [PATCH] add-log.el: Modularize add-log-current-defun, new types supported Date: Wed, 11 Apr 2012 09:49:35 -0400 Message-ID: References: <87bptf5upl.fsf@jondo.cante.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1334152218 32572 80.91.229.3 (11 Apr 2012 13:50:18 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 11 Apr 2012 13:50:18 +0000 (UTC) Cc: 2224@debbugs.gnu.org, Jari Aalto To: Lars Magne Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Apr 11 15:50:17 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SHxw4-00012P-PV for geb-bug-gnu-emacs@m.gmane.org; Wed, 11 Apr 2012 15:50:14 +0200 Original-Received: from localhost ([::1]:57296 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SHxw4-0003HR-6b for geb-bug-gnu-emacs@m.gmane.org; Wed, 11 Apr 2012 09:50:12 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:55844) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SHxvw-0003Bi-Il for bug-gnu-emacs@gnu.org; Wed, 11 Apr 2012 09:50:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SHxvn-0008Kx-VD for bug-gnu-emacs@gnu.org; Wed, 11 Apr 2012 09:50:04 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54278) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SHxvn-0008Ko-PP for bug-gnu-emacs@gnu.org; Wed, 11 Apr 2012 09:49:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SHxws-0003yw-75 for bug-gnu-emacs@gnu.org; Wed, 11 Apr 2012 09:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 Apr 2012 13:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 2224 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 2224-submit@debbugs.gnu.org id=B2224.133415224515277 (code B ref 2224); Wed, 11 Apr 2012 13:51:02 +0000 Original-Received: (at 2224) by debbugs.gnu.org; 11 Apr 2012 13:50:45 +0000 Original-Received: from localhost ([127.0.0.1]:50816 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SHxwa-0003yM-R9 for submit@debbugs.gnu.org; Wed, 11 Apr 2012 09:50:45 -0400 Original-Received: from ironport-out.teksavvy.com ([206.248.143.162]:31967) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SHxwZ-0003yF-1b for 2224@debbugs.gnu.org; Wed, 11 Apr 2012 09:50:43 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApYIACxOgk9FxL8q/2dsb2JhbABDuCMDgQyBCIIJAQEEAVYjBQsLNBIUGA0kE4gJBbYyi2GEeQSkRYFdgwM X-IronPort-AV: E=Sophos;i="4.75,391,1330923600"; d="scan'208";a="173335060" Original-Received: from 69-196-191-42.dsl.teksavvy.com (HELO pastel.home) ([69.196.191.42]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 11 Apr 2012 09:49:35 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 2033958D2B; Wed, 11 Apr 2012 09:49:35 -0400 (EDT) In-Reply-To: (Lars Magne Ingebrigtsen's message of "Wed, 11 Apr 2012 14:44:34 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:58807 Archived-At: >> The following patch breaks down monolithic `add-log-current-defun' into >> separate testing functions. Support for New buffer types is also >> provided. The patch is against version control as of 2009-02-06. > [...] >> 2009-02-06 Jari Aalto >> >> * add-log.el (add-log-current-defun): Split function into >> separate parts: add-log-current-defun-type-*. Add support >> for new types: python, ruby, Bourne Shell, Makefile, >> X?HTML, CSS, PHP, Javascript, Asciidoc. >> (add-log-current-defun-type-c-like): New function. >> (add-log-current-defun-type-tex-like): New function. >> (add-log-current-defun-type-texinfo-like): New function. >> (add-log-current-defun-type-perl-like): New function. >> (add-log-current-defun-type-python-like): New function. >> (add-log-current-defun-type-shell-ruby-like): New function. >> (add-log-current-defun-type-autoconf-like): New function. >> (add-log-current-defun-type-html-like): New function. >> (add-log-current-defun-type-css-like): New function. >> (add-log-current-defun-type-php-like): New function. >> (add-log-current-defun-type-javascript-like): New function. >> (add-log-current-defun-type-shell-bourne-like): New function. >> (add-log-current-defun-type-makefile-like): New function. >> (add-log-current-defun-type-text-asciidoc-like): New function. >> (add-log-current-defun-type-default): New function. > That's a lot of functions, but it does makes stuff clearer. Does > anybody have an opinion here? Having them be separate functions is indeed very good. But most of them shouldn't be in add-log.el: they should be in their respective major-mode instead. Stefan "and they don't need `-like' in their name"