From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#11935: XINT etc. should be functions Date: Sun, 15 Jul 2012 18:06:16 -0400 Message-ID: References: <500039B7.8050106@cs.ucla.edu> <5002C895.4080400@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1342390042 13610 80.91.229.3 (15 Jul 2012 22:07:22 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 15 Jul 2012 22:07:22 +0000 (UTC) Cc: 11935@debbugs.gnu.org, rms@gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 16 00:07:20 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SqWyC-00085i-KW for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Jul 2012 00:07:16 +0200 Original-Received: from localhost ([::1]:53836 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SqWyB-0000Ql-IZ for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Jul 2012 18:07:15 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:45967) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SqWy9-0000Qe-1n for bug-gnu-emacs@gnu.org; Sun, 15 Jul 2012 18:07:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SqWy8-0005Yg-5b for bug-gnu-emacs@gnu.org; Sun, 15 Jul 2012 18:07:12 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33656) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SqWy8-0005YW-2R for bug-gnu-emacs@gnu.org; Sun, 15 Jul 2012 18:07:12 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SqX3m-0007ff-Fm for bug-gnu-emacs@gnu.org; Sun, 15 Jul 2012 18:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 15 Jul 2012 22:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 11935-submit@debbugs.gnu.org id=B11935.134239034229441 (code B ref 11935); Sun, 15 Jul 2012 22:13:02 +0000 Original-Received: (at 11935) by debbugs.gnu.org; 15 Jul 2012 22:12:22 +0000 Original-Received: from localhost ([127.0.0.1]:43202 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SqX37-0007eo-N6 for submit@debbugs.gnu.org; Sun, 15 Jul 2012 18:12:21 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:54405) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SqX35-0007eg-6W for 11935@debbugs.gnu.org; Sun, 15 Jul 2012 18:12:20 -0400 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id q6FM6Hij030955; Sun, 15 Jul 2012 18:06:18 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 8D343AE323; Sun, 15 Jul 2012 18:06:16 -0400 (EDT) In-Reply-To: <5002C895.4080400@cs.ucla.edu> (Paul Eggert's message of "Sun, 15 Jul 2012 06:41:41 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.5 X-NAI-Spam-Rules: 2 Rules triggered SUBJ_END_DOT_WORDS=0.5, RV4280=0 X-NAI-Spam-Version: 2.2.0.9309 : core <4280> : streams <785142> : uri <1166196> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:61971 Archived-At: >> How does this change affect performance with -O0? > It hurts it. In normal operation I don't notice -- > everything is plenty fast enough -- but in an artificial > benchmark designed to stress the new code (see below) the > performance is significantly worse. If this is an issue, > we can mark these new functions with __attribute__ > ((__always_inline__)), but I'm inclined to try things > without this attribute, and resort to the attribute only if > needed. I always run with -O0 (plus ENABLE_CHECKING, and to add insult to injury, on Atom-level platforms), so I'd appreciate if you could ensure those functions are inlined even in -O0. > 1.332 1.82 current (-O0) > 1.410 11.86 patched (-O0) That would really hurt: my Emacs sessions already tend to feel sluggish without this extra pain. Stefan