From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Fix C-M-x on defcustoms Date: Tue, 07 Aug 2012 18:03:19 -0400 Message-ID: References: <87a9y6o3o8.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1344377007 1853 80.91.229.3 (7 Aug 2012 22:03:27 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 7 Aug 2012 22:03:27 +0000 (UTC) Cc: emacs-devel@gnu.org To: Jambunathan K Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 08 00:03:27 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Syrs6-0002sO-B8 for ged-emacs-devel@m.gmane.org; Wed, 08 Aug 2012 00:03:26 +0200 Original-Received: from localhost ([::1]:55085 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Syrs5-0007cw-Lt for ged-emacs-devel@m.gmane.org; Tue, 07 Aug 2012 18:03:25 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:34912) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Syrs3-0007cg-DV for emacs-devel@gnu.org; Tue, 07 Aug 2012 18:03:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Syrs2-0003gP-F3 for emacs-devel@gnu.org; Tue, 07 Aug 2012 18:03:23 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:50574) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Syrs1-0003gD-Rq for emacs-devel@gnu.org; Tue, 07 Aug 2012 18:03:22 -0400 Original-Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id q77M3KQ8001131; Tue, 7 Aug 2012 18:03:20 -0400 Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 0F4FEB4081; Tue, 7 Aug 2012 18:03:20 -0400 (EDT) In-Reply-To: <87a9y6o3o8.fsf@gmail.com> (Jambunathan K.'s message of "Wed, 08 Aug 2012 01:49:51 +0530") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Level: * X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 1 X-NAI-Spam-Rules: 2 Rules triggered NOFROM_SGMAIL=1, RV4303=0 X-NAI-Spam-Version: 2.2.0.9309 : core <4303> : streams <795976> : uri <1186387> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:152300 Archived-At: >>>>> "Jambunathan" == Jambunathan K writes: > 1. M-x find-library RET vc-dir.el > 2. C-s defcustom > 3. C-M-x. Note the following backtrace. > ,---- > | Debugger entered--Lisp error: (invalid-function (\, (lambda nil nil))) > | (\, (lambda nil nil))() > | funcall((\, (lambda nil nil))) > | eval((funcall (function (\, (lambda nil nil)))) t) > | eval-defun-1((custom-declare-variable (quote vc-dir-mode-hook) (\` > | (funcall (function (\, (lambda nil nil))))) "Normal hook run by > | vc-dir-mode'.\nSee `run-hooks'." :type (quote hook) :group (quote vc))) > | eval-defun-2() > | eval-defun(nil) > | call-interactively(eval-defun nil nil) > `---- > It looks to me that it is an issue of orphaned "comma". No, it was just a bug in eval-defun-1 which assumed that the second arg to custom-declare-variable is always a quoted constant expression, whereas it can really be any expression returning an expression. Andreas beat me to the fix, Stefan