bug#14639: package-initialize not run

bug#14639: package-initialize not run

[Juanma Barranquero]

Package: emacs
Version: 24.3.50
X-Debbugs-CC: monnier@iro.umontreal.ca


package-initialize is not being run because the code to detect
description files does

  (when (let ((subdir (expand-file-name subdir dir)))
          (and (file-directory-p subdir)
               (file-exists-p
                (package--description-file subdir))))
    (throw 'package-dir-found t)))))))

but package--description-file does not return an absolute filename, so
file-exists-p fails.

Either this patch is needed,

=== modified file 'lisp/startup.el'
--- lisp/startup.el 2013-06-15 15:36:11 +0000
+++ lisp/startup.el 2013-06-17 02:21:06 +0000
@@ -1204,5 +1204,7 @@
                          (and (file-directory-p subdir)
                               (file-exists-p
-                               (package--description-file subdir))))
+                               (expand-file-name
+                                (package--description-file subdir)
+                                subdir))))
    (throw 'package-dir-found t)))))))
        (package-initialize))


or modifying package--description-file to return an absolute path.

bug#14639: package-initialize not run

[Juanma Barranquero]

On Mon, Jun 17, 2013 at 4:34 AM, Juanma Barranquero <lekktu@gmail.com> wrote:

> or modifying package--description-file to return an absolute path.

--- lisp/startup.el 2013-06-15 15:36:11 +0000
+++ lisp/startup.el 2013-06-17 13:34:39 +0000
@@ -423,5 +423,6 @@

 (defun package--description-file (dir)
-  (concat (let ((subdir (file-name-nondirectory
+  (concat (file-name-as-directory dir)
+          (let ((subdir (file-name-nondirectory
                          (directory-file-name dir))))
             (if (string-match
"\\([^.].*?\\)-\\([0-9]+\\(?:[.][0-9]+\\|\\(?:pre\\|beta\\|alpha\\)[0-9]+\\)*\\)"
subdir)

bug#14639: package-initialize not run

[Stefan Monnier]

> -                               (package--description-file subdir))))
> +                               (expand-file-name
> +                                (package--description-file subdir)
> +                                subdir))))

Looks good (if you grep a bit, you'll see there are calls to
package--description-file which need a relative file name, because it's
used to find a file in a tar archive rather than in the file-system).


        Stefan

bug#14639: package-initialize not run

[Juanma Barranquero]

On Mon, Jun 17, 2013 at 4:45 PM, Stefan Monnier
<monnier@iro.umontreal.ca> wrote:

> Looks good (if you grep a bit, you'll see there are calls to
> package--description-file which need a relative file name, because it's
> used to find a file in a tar archive rather than in the file-system).

I see.

Committed in revno:113021