all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Glenn Morris <rgm@gnu.org>
Cc: dieter@duenenhof-wilhelm.de, 14909@debbugs.gnu.org
Subject: bug#14909: Subject: 24.3; imag-dired key-bindings not working
Date: Sat, 20 Jul 2013 04:32:55 -0400	[thread overview]
Message-ID: <jwvr4et638e.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <qcwqomb8oc.fsf@fencepost.gnu.org> (Glenn Morris's message of "Fri, 19 Jul 2013 16:23:47 -0400")

> !   (let* ((old-buf (current-buffer))
>            (dired-buf (image-dired-associated-dired-buffer))
> !          (file-name (image-dired-original-file-name))
> !          (window (image-dired-get-buffer-window dired-buf)))
>       (when (and (buffer-live-p dired-buf) file-name)
>         (set-buffer dired-buf)
>         (if (not (dired-goto-file file-name))
>             (message "Could not track file")
> !         (if window (set-window-point window (point))))
>         (set-buffer old-buf))))

I see this code could use with-current-buffer.


        Stefan





      reply	other threads:[~2013-07-20  8:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-19 15:26 bug#14909: Subject: 24.3; imag-dired key-bindings not working Dieter Wilhelm, H.
2013-07-19 20:23 ` Glenn Morris
2013-07-20  8:32   ` Stefan Monnier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvr4et638e.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=14909@debbugs.gnu.org \
    --cc=dieter@duenenhof-wilhelm.de \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.