From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Bozhidar Batsov <bozhidar@batsov.com>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: [ruby-mode] Private/protected method definition layout in Ruby 2.1
Date: Wed, 15 Jan 2014 11:24:49 -0500 [thread overview]
Message-ID: <jwvr489xlpo.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <0E94BE5F9874463D9B4C2A039A3C24E9@gmail.com> (Bozhidar Batsov's message of "Wed, 15 Jan 2014 16:41:33 +0200")
> Ruby 2.1 has made it possible to define private/protected/public
> methods on a per method basis (because a `def` now returns a symbol
> instead of nil). It means that now it’s possible to write code like
> this:
> private def map(attribute, to:)
> @rules[attribute] = to
> end
> We currently don’t support such an indentation scheme, as `def` is
> always aligned with `end`:
> private def map(attribute, to:)
> @rules[attribute] = to
> end
I presume you meant
private def map(attribute, to:)
@rules[attribute] = to
end
> I’m not saying the first alignment is preferable,
That's surprising. The current alignment just looks like a plain bug to
me and can't think of any reason why someone would prefer it over
private def map(attribute, to:)
@rules[attribute] = to
end
Of course, I don't know Ruby very well, so maybe this just shows my ignorance.
In any case, what I wanted to say here, is that in my experience, the
easiest way to handle such things with SMIE is to make the token code
treat "private def" as a single token (and to call it "def"). This may
sound silly, but trying to DTRT (for similar issues in other modes) by
tweaking grammar plus indentation rules has proved a lot more painful.
Stefan
next prev parent reply other threads:[~2014-01-15 16:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-15 14:41 [ruby-mode] Private/protected method definition layout in Ruby 2.1 Bozhidar Batsov
2014-01-15 16:24 ` Stefan Monnier [this message]
2014-01-15 18:18 ` Dmitry Gutov
2014-01-15 18:51 ` Stefan Monnier
2014-01-16 5:47 ` Dmitry Gutov
2014-01-16 10:15 ` Bozhidar Batsov
2014-01-16 13:37 ` Dmitry Gutov
2014-01-16 14:26 ` Bozhidar Batsov
2014-01-16 18:40 ` Dmitry Gutov
2014-01-16 19:38 ` Bozhidar Batsov
2014-01-17 3:17 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvr489xlpo.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=bozhidar@batsov.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.