From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#17619: 24.3; js-indent-line mixes display position with character position Date: Sat, 31 May 2014 21:30:23 -0400 Message-ID: References: <86sint4vlk.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1401586286 4358 80.91.229.3 (1 Jun 2014 01:31:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 1 Jun 2014 01:31:26 +0000 (UTC) Cc: 17619@debbugs.gnu.org To: uu1101@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 01 03:31:19 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WqucH-0002XV-5Y for geb-bug-gnu-emacs@m.gmane.org; Sun, 01 Jun 2014 03:31:17 +0200 Original-Received: from localhost ([::1]:33484 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WqucG-0007wt-Of for geb-bug-gnu-emacs@m.gmane.org; Sat, 31 May 2014 21:31:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36414) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wquc8-0007vu-Tl for bug-gnu-emacs@gnu.org; Sat, 31 May 2014 21:31:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wquc2-0002Ft-UF for bug-gnu-emacs@gnu.org; Sat, 31 May 2014 21:31:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:40392) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wquc2-0002Fp-RG for bug-gnu-emacs@gnu.org; Sat, 31 May 2014 21:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Wquc2-00035W-8N for bug-gnu-emacs@gnu.org; Sat, 31 May 2014 21:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Jun 2014 01:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17619 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17619-submit@debbugs.gnu.org id=B17619.140158623411808 (code B ref 17619); Sun, 01 Jun 2014 01:31:02 +0000 Original-Received: (at 17619) by debbugs.gnu.org; 1 Jun 2014 01:30:34 +0000 Original-Received: from localhost ([127.0.0.1]:39269 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WqubZ-00034L-Dv for submit@debbugs.gnu.org; Sat, 31 May 2014 21:30:33 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:5073) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WqubV-000344-PW for 17619@debbugs.gnu.org; Sat, 31 May 2014 21:30:30 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArUGAIDvNVPO+IOj/2dsb2JhbABZgwaDSsA9gRcXdIIlAQEBAQIBViMFCws0EhQYDTeHcQjSGReOegcWhCIBA6kZgWqBcYFbIQ X-IPAS-Result: ArUGAIDvNVPO+IOj/2dsb2JhbABZgwaDSsA9gRcXdIIlAQEBAQIBViMFCws0EhQYDTeHcQjSGReOegcWhCIBA6kZgWqBcYFbIQ X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="65208159" Original-Received: from 206-248-131-163.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([206.248.131.163]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 31 May 2014 21:30:24 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id E0831AE0BC; Sat, 31 May 2014 21:30:23 -0400 (EDT) In-Reply-To: <86sint4vlk.fsf@gmail.com> (uu's message of "Wed, 28 May 2014 20:16:39 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:89836 Archived-At: > `js-indent-line' mixes up display column with character count. Indeed. > I am using the following modification to work-around the issue, although [..] > (offset (- current-char-position (current-indentation)))) This still mixes char counts and column counts. I used the patch below instead. Stefan === modified file 'lisp/ChangeLog' --- lisp/ChangeLog 2014-05-31 20:02:47 +0000 +++ lisp/ChangeLog 2014-06-01 01:27:03 +0000 @@ -1,3 +1,8 @@ +2014-06-01 Stefan Monnier + + * progmodes/js.el (js-indent-line): Don't mix columns and chars + (bug#17619). + 2014-05-31 Stefan Monnier * subr.el (set-transient-map): Don't wait for some "nested" === modified file 'lisp/progmodes/js.el' --- lisp/progmodes/js.el 2014-05-01 23:55:25 +0000 +++ lisp/progmodes/js.el 2014-06-01 01:29:02 +0000 @@ -1907,7 +1907,7 @@ (interactive) (let* ((parse-status (save-excursion (syntax-ppss (point-at-bol)))) - (offset (- (current-column) (current-indentation)))) + (offset (- (point) (save-excursion (back-to-indentation) (point))))) (indent-line-to (js--proper-indentation parse-status)) (when (> offset 0) (forward-char offset))))