From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#17787: 24.4.50; Making `linum-mode` more efficient -- no need to run multiple times. Date: Mon, 16 Jun 2014 20:43:06 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1402965868 29735 80.91.229.3 (17 Jun 2014 00:44:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 17 Jun 2014 00:44:28 +0000 (UTC) Cc: 17787@debbugs.gnu.org To: Keith David Bershatsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 17 02:44:21 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WwhVd-0004gz-A8 for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 Jun 2014 02:44:21 +0200 Original-Received: from localhost ([::1]:46774 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WwhVc-0004G7-Sn for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Jun 2014 20:44:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53654) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WwhVS-0004EU-NA for bug-gnu-emacs@gnu.org; Mon, 16 Jun 2014 20:44:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WwhVL-0001Tv-6o for bug-gnu-emacs@gnu.org; Mon, 16 Jun 2014 20:44:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58596) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WwhVL-0001Tr-41 for bug-gnu-emacs@gnu.org; Mon, 16 Jun 2014 20:44:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WwhVK-0002xh-Dd for bug-gnu-emacs@gnu.org; Mon, 16 Jun 2014 20:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Jun 2014 00:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17787 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17787-submit@debbugs.gnu.org id=B17787.140296579911314 (code B ref 17787); Tue, 17 Jun 2014 00:44:02 +0000 Original-Received: (at 17787) by debbugs.gnu.org; 17 Jun 2014 00:43:19 +0000 Original-Received: from localhost ([127.0.0.1]:49744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WwhUZ-0002wM-Cl for submit@debbugs.gnu.org; Mon, 16 Jun 2014 20:43:15 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:32198) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WwhUW-0002w3-Ez; Mon, 16 Jun 2014 20:43:13 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArYGAIDvNVNLd+D9/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIwULCzQSFBgNJDGHUwjSGReOI1cHhDgEqRmBaoFxgVshgS0 X-IPAS-Result: ArYGAIDvNVNLd+D9/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIwULCzQSFBgNJDGHUwjSGReOI1cHhDgEqRmBaoFxgVshgS0 X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="67052016" Original-Received: from 75-119-224-253.dsl.teksavvy.com (HELO pastel.home) ([75.119.224.253]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 16 Jun 2014 20:43:06 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 1426360B51; Mon, 16 Jun 2014 20:43:06 -0400 (EDT) In-Reply-To: (Keith David Bershatsky's message of "Sun, 15 Jun 2014 12:11:52 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:90456 Archived-At: retitle 17787 Redundant runs of window-scroll-functions thanks > Here is a minor mode that can be used to test the `window-start` and > `window-end` values. A similar system can be used for `linum-mode` -- > i.e., use the `linum-update-window` from the `post-command-hook` when > point stays within the visible window limits; and, when point moves > outside those visible window limits, then use the > `window-scroll-functions` hook -- however, limit `linum-update-window` > so that it only runs when `(not (> (point) (window-end win t)))`. As Eli explained, we're not very interested in improving linum-mode. I'd rather focus on bringing nlinum-mode to feature-parity with linum-mode. admittedly, for some uses of linum-mode, the technique used by nlinum-mode has some inconvenients. But your code sounds useful, indeed for uses of window-scroll-functions which don't affect display very much (e.g. don't change window-start). This said: even if (> (point) (window-end win t)) it may be that window-scroll-functions won't be called again, because the current window-scroll-functions may change something in the current buffer (e.g. add `invisible' properties, shrink the margin, etc...) which cause (window-end win t) to move past (point). Stefan