all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Titus von der Malsburg <malsburg@posteo.de>
Cc: 18722@debbugs.gnu.org
Subject: bug#18722: Correction
Date: Thu, 16 Oct 2014 20:53:43 -0400	[thread overview]
Message-ID: <jwvr3y7msrq.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <871tq7zlyv.fsf@posteo.de> (Titus von der Malsburg's message of "Thu, 16 Oct 2014 15:31:04 -0700")

> For those who are not using git, it was this commit:
> https://lists.gnu.org/archive/html/emacs-diffs/2014-09/msg00085.html

Hmm... kind of hard to imagine how that could have such an effect.
OTOH the next commit after this one looks like a possible candidate:

    === modified file 'src/ChangeLog'
    --- src/ChangeLog       2014-09-10 16:52:50 +0000
    +++ src/ChangeLog       2014-09-10 17:02:42 +0000
    @@ -1,3 +1,8 @@
    +2014-09-10  Jan Djärv  <jan.h.d@swipnet.se>
    +
    +       * xterm.c (handle_one_xevent): Detect iconified by looking at
    +       _NET_WM_STATE_HIDDEN.
    +
     2014-09-10  Paul Eggert  <eggert@cs.ucla.edu>
     
            * lisp.h (DEFINE_GDB_SYMBOL_ENUM): Remove.
    
    === modified file 'src/xterm.c'
    --- src/xterm.c 2014-09-09 03:22:36 +0000
    +++ src/xterm.c 2014-09-10 17:02:42 +0000
    @@ -6860,6 +6860,14 @@
                 inev.ie.kind = DEICONIFY_EVENT;
                 XSETFRAME (inev.ie.frame_or_window, f);
               }
    +        else if (! FRAME_ICONIFIED_P (f)
    +                 && f->output_data.x->net_wm_state_hidden_seen)
    +          {
    +            SET_FRAME_VISIBLE (f, 0);
    +            SET_FRAME_ICONIFIED (f, 1);
    +            inev.ie.kind = ICONIFY_EVENT;
    +            XSETFRAME (inev.ie.frame_or_window, f);
    +          }
     
           x_handle_property_notify (&event->xproperty);
           xft_settings_event (dpyinfo, event);

Can you try the patch below (applied to the latest trunk code) to see if
your problem is really triggered by this commit?


        Stefan


=== modified file 'src/xterm.c'
--- src/xterm.c	2014-10-12 06:09:50 +0000
+++ src/xterm.c	2014-10-17 00:51:47 +0000
@@ -6864,14 +6864,6 @@
 	      inev.ie.kind = DEICONIFY_EVENT;
 	      XSETFRAME (inev.ie.frame_or_window, f);
 	    }
-	  else if (! FRAME_ICONIFIED_P (f)
-		   && f->output_data.x->net_wm_state_hidden_seen)
-	    {
-	      SET_FRAME_VISIBLE (f, 0);
-	      SET_FRAME_ICONIFIED (f, 1);
-	      inev.ie.kind = ICONIFY_EVENT;
-	      XSETFRAME (inev.ie.frame_or_window, f);
-	    }
 	}
 
       x_handle_property_notify (&event->xproperty);






  reply	other threads:[~2014-10-17  0:53 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-14 20:24 bug#18722: 25.0.50; UI partly unresponsive after re-focus of Emacs' window Titus von der Malsburg
2014-10-15 21:41 ` bug#18722: Correction Titus von der Malsburg
2014-10-16  8:52   ` martin rudalics
2014-10-16 10:04     ` Eli Zaretskii
2014-10-16 11:41       ` martin rudalics
2014-10-16 12:04         ` Eli Zaretskii
2014-10-16 15:16         ` Titus von der Malsburg
2014-10-16 14:46       ` Titus von der Malsburg
2014-10-16 14:54         ` Eli Zaretskii
2014-10-16 15:10           ` Titus von der Malsburg
2014-10-16 15:34             ` Eli Zaretskii
2014-10-16 15:55               ` Titus von der Malsburg
2014-10-16 21:17               ` Titus von der Malsburg
2014-10-16 22:31                 ` Titus von der Malsburg
2014-10-17  0:53                   ` Stefan Monnier [this message]
2014-10-17  4:02                     ` Titus von der Malsburg
2014-10-17 17:48                       ` Jan Djärv
2014-10-17 18:14                         ` Titus von der Malsburg
2014-10-18 12:31                           ` Jan Djärv
2014-10-19 17:09                             ` Jan Djärv
2014-10-19 18:05                               ` Titus von der Malsburg
2014-10-19 20:33                                 ` Jan Djärv
2014-10-17  9:23                   ` martin rudalics
2014-10-17 12:55                     ` Stefan Monnier
2014-10-17 16:44                     ` Titus von der Malsburg
2014-10-16 16:07         ` Stefan Monnier
2014-10-16 19:36           ` Titus von der Malsburg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvr3y7msrq.fsf-monnier+emacsbugs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=18722@debbugs.gnu.org \
    --cc=malsburg@posteo.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.