From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.help Subject: Re: Counting SLOC in Emacs Date: Fri, 28 Nov 2014 09:04:25 -0500 Message-ID: References: <877fyfk1qn.fsf@wmi.amu.edu.pl> <8761dzjvcl.fsf@wmi.amu.edu.pl> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1417183523 7331 80.91.229.3 (28 Nov 2014 14:05:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 28 Nov 2014 14:05:23 +0000 (UTC) To: help-gnu-emacs@gnu.org Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Fri Nov 28 15:05:16 2014 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XuMAb-0001oF-AX for geh-help-gnu-emacs@m.gmane.org; Fri, 28 Nov 2014 15:05:13 +0100 Original-Received: from localhost ([::1]:44504 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XuMAa-0005wy-QP for geh-help-gnu-emacs@m.gmane.org; Fri, 28 Nov 2014 09:05:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60585) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XuMA9-0005oi-Un for help-gnu-emacs@gnu.org; Fri, 28 Nov 2014 09:04:53 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XuMA2-0001SU-BM for help-gnu-emacs@gnu.org; Fri, 28 Nov 2014 09:04:45 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]:54960) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XuMA2-0001Ri-5B for help-gnu-emacs@gnu.org; Fri, 28 Nov 2014 09:04:38 -0500 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1XuMA1-0001UL-I0 for help-gnu-emacs@gnu.org; Fri, 28 Nov 2014 15:04:37 +0100 Original-Received: from 69-165-162-82.dsl.teksavvy.com ([69.165.162.82]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 28 Nov 2014 15:04:37 +0100 Original-Received: from monnier by 69-165-162-82.dsl.teksavvy.com with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 28 Nov 2014 15:04:37 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 26 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 69-165-162-82.dsl.teksavvy.com User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) Cancel-Lock: sha1:z/TlZ+83UDOVCwwoe8DJo2+7/oY= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.help:101268 Archived-At: > (save-excursion > (save-restriction > (narrow-to-region beg end) > (goto-char (point-min)) > (let ((count 0)) > (while (not (eobp)) I'd use (save-excursion (goto-char beg (let ((count 0)) (while (< (point) end) since narrowing can have all kinds of weird effects. > (message "SLOC in %s: %s." > (if (use-region-p) "region" "buffer") > count))))) And don't re-call use-region-p here, in the off-chance that it returns something else than in the first call. E.g. you can use (if (and (= beg (point-min)) (= end (point-max))) "buffer" "region") instead. Stefan