From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Requesting review before pushing patch to ELPA Date: Thu, 05 Feb 2015 09:10:50 -0500 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1423145698 15342 80.91.229.3 (5 Feb 2015 14:14:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 5 Feb 2015 14:14:58 +0000 (UTC) Cc: emacs-devel To: Jackson Hamilton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 05 15:14:58 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YJNCr-00012v-8t for ged-emacs-devel@m.gmane.org; Thu, 05 Feb 2015 15:14:57 +0100 Original-Received: from localhost ([::1]:42205 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJNCq-0004Yb-MP for ged-emacs-devel@m.gmane.org; Thu, 05 Feb 2015 09:14:56 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52060) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJN91-0006nS-AT for emacs-devel@gnu.org; Thu, 05 Feb 2015 09:10:59 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YJN8v-0002D8-3a for emacs-devel@gnu.org; Thu, 05 Feb 2015 09:10:59 -0500 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:38596) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJN8u-0002Cz-MW for emacs-devel@gnu.org; Thu, 05 Feb 2015 09:10:53 -0500 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t15EAokK017520; Thu, 5 Feb 2015 09:10:51 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id B65C2FB3; Thu, 5 Feb 2015 09:10:50 -0500 (EST) In-Reply-To: (Jackson Hamilton's message of "Thu, 5 Feb 2015 00:05:41 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5208=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5208> : inlines <2034> : streams <1385180> : uri <1847065> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:182445 Archived-At: > The attached patches are the current representation of what I intend to > merge. (Same subtree strategy as before.) Looks good to me, Stefan PS: Regarding "eval: (when (fboundp 'rainbow-mode) (rainbow-mode 1))", this is usually considered a misfeature: the file does not need or make special use of rainbow-mode. Instead, *you* just happen to like using rainbow-mode when editing this file. So this customization should be in your ~/.emacs rather than in the file itself.