From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] scratch/check-declare e7e278c 1/2: check-declare.el (check-declare-ext-errors): New defcustom. Date: Fri, 13 Feb 2015 15:17:14 -0500 Message-ID: References: <20150213140806.27897.63152@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1423858685 13235 80.91.229.3 (13 Feb 2015 20:18:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 13 Feb 2015 20:18:05 +0000 (UTC) Cc: Oleh Krehel To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 13 21:17:56 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YMMgU-0002CH-Ii for ged-emacs-devel@m.gmane.org; Fri, 13 Feb 2015 21:17:54 +0100 Original-Received: from localhost ([::1]:57350 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YMMgT-0008Lo-NO for ged-emacs-devel@m.gmane.org; Fri, 13 Feb 2015 15:17:53 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35553) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YMMgH-0008Lj-DO for emacs-devel@gnu.org; Fri, 13 Feb 2015 15:17:42 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YMMgD-0001RC-Vu for emacs-devel@gnu.org; Fri, 13 Feb 2015 15:17:41 -0500 Original-Received: from mercure.iro.umontreal.ca ([132.204.24.67]:52867) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YMMgD-0001Qy-N5 for emacs-devel@gnu.org; Fri, 13 Feb 2015 15:17:37 -0500 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 85D3C85EB6; Fri, 13 Feb 2015 15:17:37 -0500 (EST) Original-Received: from lechon.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 88C751E5B8A; Fri, 13 Feb 2015 15:17:14 -0500 (EST) Original-Received: by lechon.iro.umontreal.ca (Postfix, from userid 20848) id 676D5B4102; Fri, 13 Feb 2015 15:17:14 -0500 (EST) In-Reply-To: (Oleh Krehel's message of "Fri, 13 Feb 2015 14:08:07 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82, MC_TSTLAST 0.00) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 132.204.24.67 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:183024 Archived-At: > +(defgroup check-declare nil > + "Check declare-function statements" > + :group 'tools) I think you need a "." at the end of these docstrings. C-u M-x checkdoc-current-buffer might flag those things (along with others with which I don't always agree ;-) > +(defcustom check-declare-ext-errors nil > + "When non-nil, warn abount functions not found in :ext" > + :group 'check-declare) This :group is redundant. OTOH you need a ":type 'boolean". > + (cl-letf ((warning-prefix-function Why cl-letf? Stefan